Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Side by Side Diff: third_party/WebKit/Source/core/frame/LocalFrame.h

Issue 2449673002: Refactor InspectorWebPerfAgent: update lifecycle management to be per Local Frame root; replace hea… (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org> 2 * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org>
3 * 1999-2001 Lars Knoll <knoll@kde.org> 3 * 1999-2001 Lars Knoll <knoll@kde.org>
4 * 1999-2001 Antti Koivisto <koivisto@kde.org> 4 * 1999-2001 Antti Koivisto <koivisto@kde.org>
5 * 2000-2001 Simon Hausmann <hausmann@kde.org> 5 * 2000-2001 Simon Hausmann <hausmann@kde.org>
6 * 2000-2001 Dirk Mueller <mueller@kde.org> 6 * 2000-2001 Dirk Mueller <mueller@kde.org>
7 * 2000 Stefan Schimanski <1Stein@gmx.de> 7 * 2000 Stefan Schimanski <1Stein@gmx.de>
8 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights 8 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights
9 * reserved. 9 * reserved.
10 * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies) 10 * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies)
(...skipping 42 matching lines...) Expand 10 before | Expand all | Expand 10 after
53 class Element; 53 class Element;
54 template <typename Strategy> 54 template <typename Strategy>
55 class EphemeralRangeTemplate; 55 class EphemeralRangeTemplate;
56 class EventHandler; 56 class EventHandler;
57 class FloatSize; 57 class FloatSize;
58 class FrameConsole; 58 class FrameConsole;
59 class FrameSelection; 59 class FrameSelection;
60 class FrameView; 60 class FrameView;
61 class HTMLPlugInElement; 61 class HTMLPlugInElement;
62 class InputMethodController; 62 class InputMethodController;
63 class InspectorWebPerfAgent;
64 class InstrumentingAgents;
63 class InterfaceProvider; 65 class InterfaceProvider;
64 class InterfaceRegistry; 66 class InterfaceRegistry;
65 class IntPoint; 67 class IntPoint;
66 class IntSize; 68 class IntSize;
67 class InstrumentingAgents;
68 class JSONObject; 69 class JSONObject;
69 class LayoutView; 70 class LayoutView;
70 class LayoutViewItem; 71 class LayoutViewItem;
71 class LocalDOMWindow; 72 class LocalDOMWindow;
72 class NavigationScheduler; 73 class NavigationScheduler;
73 class Node; 74 class Node;
74 class NodeTraversal; 75 class NodeTraversal;
75 template <typename Strategy> 76 template <typename Strategy>
76 class PositionWithAffinityTemplate; 77 class PositionWithAffinityTemplate;
77 class PluginData; 78 class PluginData;
(...skipping 78 matching lines...) Expand 10 before | Expand all | Expand 10 after
156 // change. 157 // change.
157 // In addition, this function will always return true for a detached frame. 158 // In addition, this function will always return true for a detached frame.
158 // TODO(dcheng): Move this to LocalDOMWindow and figure out the right 159 // TODO(dcheng): Move this to LocalDOMWindow and figure out the right
159 // behavior for detached windows. 160 // behavior for detached windows.
160 bool isCrossOriginSubframe() const; 161 bool isCrossOriginSubframe() const;
161 162
162 InstrumentingAgents* instrumentingAgents() { 163 InstrumentingAgents* instrumentingAgents() {
163 return m_instrumentingAgents.get(); 164 return m_instrumentingAgents.get();
164 } 165 }
165 166
167 InspectorWebPerfAgent* inspectorWebPerfAgent() {
caseq 2016/10/26 21:19:41 Do we really need to expose it?
panicker 2016/10/28 00:09:24 Removed
168 return m_inspectorWebPerfAgent.get();
169 }
170
171 void enableInspectorWebPerfAgent();
172 void disableInspectorWebPerfAgent();
173
166 // ========================================================================= 174 // =========================================================================
167 // All public functions below this point are candidates to move out of 175 // All public functions below this point are candidates to move out of
168 // LocalFrame into another class. 176 // LocalFrame into another class.
169 177
170 // See GraphicsLayerClient.h for accepted flags. 178 // See GraphicsLayerClient.h for accepted flags.
171 String layerTreeAsText(unsigned flags = 0) const; 179 String layerTreeAsText(unsigned flags = 0) const;
172 180
173 void setPrinting(bool printing, 181 void setPrinting(bool printing,
174 const FloatSize& pageSize, 182 const FloatSize& pageSize,
175 const FloatSize& originalPageSize, 183 const FloatSize& originalPageSize,
(...skipping 83 matching lines...) Expand 10 before | Expand all | Expand 10 after
259 const Member<InputMethodController> m_inputMethodController; 267 const Member<InputMethodController> m_inputMethodController;
260 268
261 int m_navigationDisableCount; 269 int m_navigationDisableCount;
262 270
263 float m_pageZoomFactor; 271 float m_pageZoomFactor;
264 float m_textZoomFactor; 272 float m_textZoomFactor;
265 273
266 bool m_inViewSourceMode; 274 bool m_inViewSourceMode;
267 275
268 Member<InstrumentingAgents> m_instrumentingAgents; 276 Member<InstrumentingAgents> m_instrumentingAgents;
277 Member<InspectorWebPerfAgent> m_inspectorWebPerfAgent;
278 unsigned m_inspectorWebPerfAgentObservers;
269 279
270 InterfaceProvider* const m_interfaceProvider; 280 InterfaceProvider* const m_interfaceProvider;
271 InterfaceRegistry* const m_interfaceRegistry; 281 InterfaceRegistry* const m_interfaceRegistry;
272 }; 282 };
273 283
274 inline void LocalFrame::init() { 284 inline void LocalFrame::init() {
275 m_loader.init(); 285 m_loader.init();
276 } 286 }
277 287
278 inline LocalDOMWindow* LocalFrame::localDOMWindow() const { 288 inline LocalDOMWindow* LocalFrame::localDOMWindow() const {
(...skipping 92 matching lines...) Expand 10 before | Expand all | Expand 10 after
371 explicit ScopedFrameBlamer(LocalFrame*); 381 explicit ScopedFrameBlamer(LocalFrame*);
372 ~ScopedFrameBlamer(); 382 ~ScopedFrameBlamer();
373 383
374 private: 384 private:
375 Member<LocalFrame> m_frame; 385 Member<LocalFrame> m_frame;
376 }; 386 };
377 387
378 } // namespace blink 388 } // namespace blink
379 389
380 #endif // LocalFrame_h 390 #endif // LocalFrame_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698