MD Settings: Implement search URLs.

chrome/browser/resources/settings/settings_main/settings_main.js

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @typedef {{about: boolean, basic: boolean, advanced: boolean}}
  */
 var MainPageVisibility;
 
 /**
@@ skipping 68 matching lines @@
     },
 
     /**
      * Dictionary defining page visibility.
      * @type {!GuestModePageVisibility}
      */
     pageVisibility: {
       type: Object,
       value: function() { return {}; },
     },
+
+    /** @private */
+    searchQuery: {

[tommycli, 2016/11/01 21:05:26]

Looks like settings-ui is messing with this. In that case, it's not private
right?

Might be worth adding a comment that it's populated from settings-ui also
instead of internally.

Finally - if the only usage of this property is to trigger calling
searchContents, maybe just have settings_ui directly call searchContents? Maybe
this hurts encapsulation a little bit - but parent elements are allow to call
methods on contained elements right?

[dpapad, 2016/11/01 22:02:02]

Removed searchQuery property per suggestion.

+      type: String,
+      value: '',
+      observer: 'searchQueryChanged_',
+    },
   },
 
   /** @override */
   attached: function() {
     var currentRoute = settings.getCurrentRoute();
     this.hasExpandedSection_ = currentRoute && currentRoute.isSubpage();
   },
 
   /** @private */
   overscrollChanged_: function() {
@@ skipping 100 matching lines @@
     // update hasExpandedSection_ to unhide the other sections.
     if (!newRoute.isSubpage())
       this.hasExpandedSection_ = false;
 
     if (settings.Route.ADVANCED.contains(newRoute))
       this.advancedToggleExpanded = true;
 
     this.updatePagesShown_();
   },
 
+  /**
+   * @param {string} current
+   * @param {string} previous
+   * @private
+   */
+  searchQueryChanged_: function(current, previous) {
+    // Ignore change triggered by initialization.
+    if (previous == undefined)
+      return;
+
+    this.searchContents(this.searchQuery);
+  },
+
   /** @private */
   onSubpageExpand_: function() {
     // The subpage finished expanding fully. Hide pages other than the current
     // section's parent page.
     this.hasExpandedSection_ = true;
     this.updatePagesShown_();
   },
 
   /**
    * Updates the hidden state of the about, basic and advanced pages, based on
@@ skipping 87 matching lines @@
           this.$$('settings-advanced-page'));
     }
     if (settings.Route.BASIC.contains(route)) {
       return /** @type {?SettingsBasicPageElement} */(
           this.$$('settings-basic-page'));
     }
     assertNotReached();
   },
 
   /**
-   * Navigates to the default search page (if necessary).
-   * @private
-   */
-  ensureInDefaultSearchPage_: function() {
-    if (settings.getCurrentRoute() != settings.Route.BASIC)
-      settings.navigateTo(settings.Route.BASIC);
-  },
-
-  /**
    * @param {string} query
    * @return {!Promise} A promise indicating that searching finished.
    */
   searchContents: function(query) {
     // Trigger rendering of the basic and advanced pages and search once ready.
     this.inSearchMode_ = true;
-    this.ensureInDefaultSearchPage_();
     this.toolbarSpinnerActive = true;
 
     return new Promise(function(resolve, reject) {
       setTimeout(function() {
         var whenSearchDone = settings.getSearchManager().search(
             query, assert(this.getPage_(settings.Route.BASIC)));
         assert(
             whenSearchDone ===
                 settings.getSearchManager().search(
                     query, assert(this.getPage_(settings.Route.ADVANCED))));
@@ skipping 18 matching lines @@
 
   /**
    * @param {(boolean|undefined)} visibility
    * @return {boolean} True unless visibility is false.
    * @private
    */
   showAdvancedSettings_: function(visibility) {
     return visibility !== false;
   },
 });