MD Settings: Implement search URLs.

chrome/browser/resources/settings/settings_ui/settings_ui.js

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview
  * 'settings-ui' implements the UI for the Settings page.
  *
  * Example:
  *
  *    <settings-ui prefs="{{prefs}}"></settings-ui>
  */
 cr.exportPath('settings');
 assert(!settings.defaultResourceLoaded,
        'settings_ui.js run twice. You probably have an invalid import.');
 /** Global defined when the main Settings script runs. */
 settings.defaultResourceLoaded = true;
 
 Polymer({
   is: 'settings-ui',
 
+  behaviors: [settings.RouteObserverBehavior],
+
   properties: {
     /**
      * Preferences state.
      */
     prefs: Object,
 
     /** @type {?settings.DirectionDelegate} */
     directionDelegate: {
       observer: 'directionDelegateChanged_',
       type: Object,
@@ skipping 24 matching lines @@
   created: function() {
     settings.initializeRouteFromUrl();
   },
 
   /**
    * @override
    * @suppress {es5Strict} Object literals cannot contain duplicate keys in ES5
    *     strict mode.
    */
   ready: function() {
-    this.$$('cr-toolbar').addEventListener('search-changed', function(e) {
-      this.$$('settings-main').searchContents(e.detail);
-    }.bind(this));
+    this.$$('cr-toolbar').addEventListener(
+        'search-changed', this.onSearchChanged_.bind(this));

[Dan Beam, 2016/10/26 01:24:36]

any reason why we can't do on-search-changed="onSearchChanged_" in the HTML?

[dpapad, 2016/10/26 01:31:27]

Yes, I'll add a comment to make this more obvious. cr-toolbar-search-field
unfortunately (probably a bug we should fix), fires an accidental search-changed
event during its initialization, which is hard to ignore if we add the listener
in HTML. Adding the listener in 'ready' works around this issue. 

[Dan Beam, 2016/10/26 20:50:52]

that's a pretty lame work around.  why does triggering with the same value
matter if query == existingQuery no-ops?

[dpapad, 2016/10/26 21:02:57]

Well, you are right that it does not matter anymore, so done. Before it would
trigger an unnecessary search on startup.

 
     // Lazy-create the drawer the first time it is opened or swiped into view.
     var drawer = assert(this.$$('app-drawer'));
     listenOnce(drawer, 'track opened-changed', function() {
       this.$.drawerTemplate.if = true;
     }.bind(this));
 
     window.addEventListener('popstate', function(e) {
       drawer.close();
     }.bind(this));
@@ skipping 30 matching lines @@
     }
   },
 
   /** @override */
   attached: function() {
     // Preload bold Roboto so it doesn't load and flicker the first time used.
     document.fonts.load('bold 12px Roboto');
     settings.setGlobalScrollTarget(this.$.headerPanel.scroller);
   },
 
+  /** @param {!settings.Route} newRoute */
+  currentRouteChanged: function(newRoute) {
+    var searchQuery = settings.getQueryParameters().get('search') || '';
+    var toolbar = /** @type {!CrToolbarElement} */ (this.$$('cr-toolbar'));
+    var searchField = /** @type {CrToolbarSearchFieldElement} */ (
+        toolbar.getSearchField());
+    searchField.setValue(searchQuery);
+  },
+
+  /**
+   * @param {!Event} e
+   * @private
+   */
+  onSearchChanged_: function(e) {
+    var query = e.detail;
+
+    // 'search-changed' event was fired only because the search box's value was
+    // updated to reflect the already existing search URL parameter, no need to
+    // navigate again.
+    var existingQuery = settings.getQueryParameters().get('search') || '';
+    if (query == existingQuery)
+      return;
+
+    settings.navigateTo(
+        settings.Route.BASIC,
+        query.length > 0 ? new URLSearchParams(`search=${query}`) : undefined);
+  },
+
   /**
    * @param {Event} event
    * @private
    */
   onIronActivate_: function(event) {
     if (event.detail.item.id != 'advancedPage')
       this.$$('app-drawer').close();
   },
 
   /** @private */
   onMenuButtonTap_: function() {
     this.$$('app-drawer').toggle();
   },
 
   /** @private */
   directionDelegateChanged_: function() {
     this.$$('app-drawer').align = this.directionDelegate.isRtl() ?
         'right' : 'left';
   },
 });