cros: Updated autoclick section for md-settings.

cros: Updated autoclick section for md-settings.

Changed autoclick options strings. Also made autoclick options disabled when autoclick is not enabled.

BUG=610476, 629425
TEST=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/064a1ca8e1b1f3d7f5c6e315598d638c55a0fc6e
Cr-Commit-Position: refs/heads/master@{#427429}

[sammiequon, 2016-10-24 20:58:38]

Description was changed from

==========
cros: Changed autoclick options strings. Also made autoclick options disabled
when autoclick is not enabled.

BUG=610476, 629425
TEST=none
==========

to

==========
cros: Changed autoclick options strings. Also made autoclick options disabled
when autoclick is not enabled.

BUG=610476, 629425
TEST=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[sammiequon, 2016-10-24 21:14:49]

Description was changed from

==========
cros: Changed autoclick options strings. Also made autoclick options disabled
when autoclick is not enabled.

BUG=610476, 629425
TEST=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
cros: Changed autoclick options strings. Also made autoclick options disabled
when autoclick is not enabled.

I also changed settings strings to placeholders so that the autoclick option
values and descriptions are changed in the same place.

BUG=610476, 629425
TEST=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[sammiequon, 2016-10-24 21:14:49]

sammiequon@chromium.org changed reviewers:
+ dmazzoni@chromium.org, michaelpg@chromium.org

[sammiequon, 2016-10-24 21:15:07]

On 2016/10/24 21:14:49, sammiequon wrote:
> mailto:sammiequon@chromium.org changed reviewers:
> + mailto:dmazzoni@chromium.org, mailto:michaelpg@chromium.org

dmazzoni@, michaelpg@ - Please take a look. Thanks!

[michaelpg, 2016-10-24 21:33:27]

nlgtm -- these strings needs to be internationalized.

There are probably ways to dynamically generate an i18n-compliant time string
(see base/i18n/time_formatting.h) but even then I'm not sure those can just be
dropped into a longer string like "Very short (<time>)" due to language
differences.

Very much in favor of using seconds instead of milliseconds though :-)

[sammiequon, 2016-10-24 21:55:26]

Description was changed from

==========
cros: Changed autoclick options strings. Also made autoclick options disabled
when autoclick is not enabled.

I also changed settings strings to placeholders so that the autoclick option
values and descriptions are changed in the same place.

BUG=610476, 629425
TEST=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
cros: Changed autoclick options strings. Also made autoclick options disabled
when autoclick is not enabled.

BUG=610476, 629425
TEST=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[sammiequon, 2016-10-24 21:56:25]

On 2016/10/24 21:33:27, michaelpg wrote:
> nlgtm -- these strings needs to be internationalized.
> 
> There are probably ways to dynamically generate an i18n-compliant time string
> (see base/i18n/time_formatting.h) but even then I'm not sure those can just be
> dropped into a longer string like "Very short (<time>)" due to language
> differences.
> 
> Very much in favor of using seconds instead of milliseconds though :-)

I removed that particular change. I can look into dynamically changing it in the
future if it is required.

[michaelpg, 2016-10-24 22:09:45]

lgtm

[michaelpg, 2016-10-24 22:10:04]

On 2016/10/24 22:09:45, michaelpg wrote:
> lgtm

Though you should shorten the title for the commit message.

[sammiequon, 2016-10-24 22:19:06]

Description was changed from

==========
cros: Changed autoclick options strings. Also made autoclick options disabled
when autoclick is not enabled.

BUG=610476, 629425
TEST=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
cros: Updated autoclick section for md-settings.

Changed autoclick options strings. Also made autoclick options disabled when
autoclick is not enabled.

BUG=610476, 629425
TEST=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[sammiequon, 2016-10-24 22:20:09]

The CQ bit was checked by sammiequon@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-24 22:21:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-24 22:57:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-24 22:57:27]

Dry run: Try jobs failed on following builders:
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)

[dmazzoni, 2016-10-25 16:59:47]

lgtm

[sammiequon, 2016-10-25 17:00:38]

The CQ bit was checked by sammiequon@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-25 17:01:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-25 17:46:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-25 17:46:28]

Dry run: This issue passed the CQ dry run.

[sammiequon, 2016-10-25 17:48:02]

The CQ bit was checked by sammiequon@chromium.org

[commit-bot: I haz the power, 2016-10-25 17:48:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-25 17:59:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-25 17:59:02]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[sammiequon, 2016-10-25 18:32:28]

sammiequon@chromium.org changed reviewers:
+ stevenjb@chromium.org

[sammiequon, 2016-10-25 18:32:52]

On 2016/10/25 17:59:02, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

stevenjb@ - Please take a look at browser_options.html. Thanks!

[stevenjb, 2016-10-25 18:46:32]

https://codereview.chromium.org/2449643002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/options/browser_options.html (right):

https://codereview.chromium.org/2449643002/diff/20001/chrome/browser/resource...
chrome/browser/resources/options/browser_options.html:954: timing gets changed,
then the i18n strings also needs to be
Note: generally trivial spelling fixes should be done with other changes to the
file, but lgtm.

[sammiequon, 2016-10-25 18:50:30]

The CQ bit was checked by sammiequon@chromium.org

[commit-bot: I haz the power, 2016-10-25 18:51:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-25 18:56:09]

Description was changed from

==========
cros: Updated autoclick section for md-settings.

Changed autoclick options strings. Also made autoclick options disabled when
autoclick is not enabled.

BUG=610476, 629425
TEST=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
cros: Updated autoclick section for md-settings.

Changed autoclick options strings. Also made autoclick options disabled when
autoclick is not enabled.

BUG=610476, 629425
TEST=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[commit-bot: I haz the power, 2016-10-25 18:56:09]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-25 19:09:25]

Description was changed from

==========
cros: Updated autoclick section for md-settings.

Changed autoclick options strings. Also made autoclick options disabled when
autoclick is not enabled.

BUG=610476, 629425
TEST=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
cros: Updated autoclick section for md-settings.

Changed autoclick options strings. Also made autoclick options disabled when
autoclick is not enabled.

BUG=610476, 629425
TEST=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/064a1ca8e1b1f3d7f5c6e315598d638c55a0fc6e
Cr-Commit-Position: refs/heads/master@{#427429}
==========

[commit-bot: I haz the power, 2016-10-25 19:09:26]

Patchset 2 (id:??) landed as
https://crrev.com/064a1ca8e1b1f3d7f5c6e315598d638c55a0fc6e
Cr-Commit-Position: refs/heads/master@{#427429}