Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(779)

Issue 2449573003: Data race fix: Replace use of MessageLoop raw pointer in MSAudioProcessor. (Closed)

Created:
4 years, 1 month ago by miu
Modified:
4 years, 1 month ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2883
Project:
chromium
Visibility:
Public.

Description

Data race fix: Replace use of MessageLoop raw pointer in MSAudioProcessor. This change replaces the use of a raw pointer to the main thread's MessageLoop, by content::MediaStreamAudioProcessor, with a scoped_refptr to the main thread's task runner. This fixes a TSan-reported shutdown data race which was caused by the MessageLoop releasing its task runner at the same time the audio thread was using the MessageLoop::task_runner() accessor method. BUG=647178 Review-Url: https://chromiumcodereview.appspot.com/2425353002 Cr-Commit-Position: refs/heads/master@{#426318} (cherry picked from commit a4717b9caba5b1fb1e4455af8932a3a870a9aecf) Committed: https://chromium.googlesource.com/chromium/src/+/6f8fc5767534da6ea3682ab3bde09e782909467b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -24 lines) Patch
M content/renderer/media/media_stream_audio_processor.h View 3 chunks +8 lines, -6 lines 0 comments Download
M content/renderer/media/media_stream_audio_processor.cc View 11 chunks +15 lines, -12 lines 0 comments Download
M content/renderer/media/media_stream_audio_processor_unittest.cc View 6 chunks +5 lines, -6 lines 0 comments Download
M content/renderer/media/webrtc/processed_local_audio_source_unittest.cc View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
miu
4 years, 1 month ago (2016-10-24 21:47:13 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
6f8fc5767534da6ea3682ab3bde09e782909467b.

Powered by Google App Engine
This is Rietveld 408576698