Issue 2449563003: Stop media stream source when audio capture error occurs. This is to ensure that session ends when …

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2449563003: Stop media stream source when audio capture error occurs. This is to ensure that session ends when … (Closed)

Created:
4 years, 1 month ago by miu

Modified:
4 years, 1 month ago

Reviewers:

CC:
chromium-reviews

Target Ref:
refs/pending/branch-heads/2883

Project:
chromium

Visibility:
Public.

More Reviews

Description

Stop media stream source when audio capture error occurs. This is to ensure that session ends when closing the tab while audio is mirroring. BUG=655841 Review-Url: https://chromiumcodereview.appspot.com/2416123002 Cr-Commit-Position: refs/heads/master@{#426400} (cherry picked from commit 9d67562879f4cbddb2c1ddd08225310cea891490)

Patch Set 1 #

Created: 4 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+41 lines, -19 lines)			Patch
M	content/renderer/media/external_media_stream_audio_source.cc	View	1 chunk	+1 line, -4 lines	0 comments	Download
M	content/renderer/media/local_media_stream_audio_source.cc	View	1 chunk	+1 line, -4 lines	0 comments	Download
M	content/renderer/media/media_stream_audio_source.h	View	3 chunks	+14 lines, -4 lines	0 comments	Download
M	content/renderer/media/media_stream_audio_source.cc	View	6 chunks	+18 lines, -7 lines	0 comments	Download
M	content/renderer/media/media_stream_audio_unittest.cc	View	2 chunks	+3 lines, -0 lines	0 comments	Download
M	content/renderer/media/speech_recognition_audio_sink_unittest.cc	View	2 chunks	+3 lines, -0 lines	0 comments	Download
M	content/renderer/media/webrtc/processed_local_audio_source.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

miu

4 years, 1 month ago (2016-10-24 21:51:47 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 (id:1) to pending queue manually as
4316f0954d3573cb0387a13c25a37b884ce130f4.

Expand Messages | Collapse Messages