Issue 2449503002: Change build.py to invoke gn with '--check' to match the build bot's script and Flutter's usage.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2449503002: Change build.py to invoke gn with '--check' to match the build bot's script and Flutter's usage. (Closed)

Created:
4 years, 1 month ago by rmacnak

Modified:
4 years, 1 month ago

Reviewers:
zra

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Change build.py to invoke gn with '--check' to match the build bot's script and Flutter's usage. R=zra@google.com Committed: https://github.com/dart-lang/sdk/commit/e109c9bb0e9afd781d171a3b0948cc97aed51b43

Created: 4 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	tools/build.py	View		1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 5 (2 generated)

rmacnak

4 years, 1 month ago (2016-10-25 16:43:43 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
e109c9bb0e9afd781d171a3b0948cc97aed51b43 (presubmit successful).