Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issue 2449473003: Log to UMA why we would load a third-party frame (Closed)

Created:
4 years, 1 month ago by dgrogan
Modified:
4 years, 1 month ago
Reviewers:
Ilya Sherman
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2883
Project:
chromium
Visibility:
Public.

Description

Log to UMA why we would load a third-party frame This will give an estimate of the % of iframes that we can defer loading. We can defer offscreen frames unless they are probably used for cross-origin communication. Reland of https://codereview.chromium.org/2389023002 BUG=635105 TBR=isherman@chromium.org Review-Url: https://chromiumcodereview.appspot.com/2437193002 Cr-Commit-Position: refs/heads/master@{#426979} (cherry picked from commit c301da12f702e16e64faf04524f89bde02ad9588) Committed: https://chromium.googlesource.com/chromium/src/+/5ca7d242d3f11698547c96b3c2aacd8b5b0171ea

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+271 lines, -30 lines) Patch
M third_party/WebKit/Source/core/dom/Document.h View 3 chunks +26 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Document.cpp View 4 chunks +12 lines, -26 lines 0 comments Download
M third_party/WebKit/Source/core/frame/FrameView.cpp View 3 chunks +20 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
A third_party/WebKit/Source/web/tests/DeferredLoadingTest.cpp View 1 chunk +187 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 3 chunks +22 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
dgrogan
4 years, 1 month ago (2016-10-24 18:38:31 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
5ca7d242d3f11698547c96b3c2aacd8b5b0171ea.

Powered by Google App Engine
This is Rietveld 408576698