Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(326)

Issue 2449473002: PPC/s390: [full-codegen] Eliminate unnecessary hole checks for stores (Closed)

Created:
4 years, 1 month ago by yangtian.zi
Modified:
4 years, 1 month ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC/s390: [full-codegen] Eliminate unnecessary hole checks for stores Port 231c8ac0a78dd3d28f5398452c139062430ff008 Original commit message: Loads already used source position elimination to avoid unnecessary hole checks, but for reasons unknown stores did not. This CL corrects that, making full-codegen's hole elimination equivalent to ignition's. Also introduced a HoleCheckMode enum class to avoid more bool flags and updated VariableProxy and BytecodeGenerator appropriately. R=adamk@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, bjaideep@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com BUG= Committed: https://crrev.com/e39a7c7187817227d5c47df4603d2c3431bff6cb Cr-Commit-Position: refs/heads/master@{#40538}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -27 lines) Patch
M src/full-codegen/ppc/full-codegen-ppc.cc View 7 chunks +19 lines, -14 lines 0 comments Download
M src/full-codegen/s390/full-codegen-s390.cc View 7 chunks +19 lines, -13 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
JaideepBajwa
lgtm
4 years, 1 month ago (2016-10-24 14:45:15 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2449473002/1
4 years, 1 month ago (2016-10-24 14:53:55 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 1 month ago (2016-10-24 14:53:57 UTC) #5
john.yan
lgtm
4 years, 1 month ago (2016-10-24 15:44:20 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2449473002/1
4 years, 1 month ago (2016-10-24 16:04:16 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-24 16:33:45 UTC) #9
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:11:21 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e39a7c7187817227d5c47df4603d2c3431bff6cb
Cr-Commit-Position: refs/heads/master@{#40538}

Powered by Google App Engine
This is Rietveld 408576698