src/ic/ic-inl.h - Issue 2449463002: [ic] Load IC data handlers now support prototype chain checks with global and dictionary objects.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ic/ic-inl.h

Issue 2449463002: [ic] Load IC data handlers now support prototype chain checks with global and dictionary objects. (Closed)

Patch Set: Addressing comments and fixing the handlers in new space issue Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/ic/ic-inl.h

diff --git a/src/ic/ic-inl.h b/src/ic/ic-inl.h

index c83c30ca459ac7da410464b18dd79580bac778d5..1b5d0632700db1a41d9cde4eb73f9f307da73014 100644

--- a/src/ic/ic-inl.h

+++ b/src/ic/ic-inl.h

@@ -93,7 +93,8 @@ Code* IC::target() const {

}

bool IC::IsHandler(Object* object) {

- return (object->IsSmi() && (object != nullptr)) || (object->IsTuple3()) ||

+ return (object->IsSmi() && (object != nullptr)) || object->IsTuple3() ||

+ object->IsFixedArray() ||

(object->IsCode() && Code::cast(object)->is_handler());

}

« no previous file with comments | « src/ic/ic.cc ('k') | src/ic/mips/handler-compiler-mips.cc » ('j') | no next file with comments »