Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 2449433002: Fix more null-checks in SVGLengthContext::convertValueFrom* (Closed)

Created:
4 years, 1 month ago by fs
Modified:
4 years, 1 month ago
Reviewers:
pdr., eae
CC:
fs, blink-reviews, chromium-reviews, krit, f(malita), gyuyoung2, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix more null-checks in SVGLengthContext::convertValueFrom* The following methods in SVGLengthContext: convertValueFromUserUnitsToCHS convertValueFromUserUnitsToEXS convertValueFromEXSToUserUnits needs the same treatment as convertValueFromCHSToUserUnits got in https://chromiumcodereview.appspot.com/2445463002. R=pdr@chromium.org,eae@chromium.org BUG=657438, 658585, 658613 Committed: https://crrev.com/4c55d78bcbaff133a4e688eddc7573e0609cf190 Cr-Commit-Position: refs/heads/master@{#427080}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -10 lines) Patch
M third_party/WebKit/Source/core/svg/SVGLengthContext.cpp View 3 chunks +9 lines, -10 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
fs
4 years, 1 month ago (2016-10-24 12:41:12 UTC) #3
eae
LGTM, thank you
4 years, 1 month ago (2016-10-24 16:03:36 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2449433002/1
4 years, 1 month ago (2016-10-24 16:04:03 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-24 16:18:51 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-10-24 16:49:54 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4c55d78bcbaff133a4e688eddc7573e0609cf190
Cr-Commit-Position: refs/heads/master@{#427080}

Powered by Google App Engine
This is Rietveld 408576698