Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Issue 24494003: [webcrypto] Move the files to a subdirectory (content/renderer/webcrypto). (Closed)

Created:
7 years, 2 months ago by eroman
Modified:
7 years, 2 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, Bryan Eyler, Ryan Sleevi
Visibility:
Public.

Description

[webcrypto] Move the files to a subdirectory (content/renderer/webcrypto). BUG=245025 R=jamesr@chromium.org, jochen@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=225659

Patch Set 1 : #

Patch Set 2 : #

Patch Set 3 : rebase #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -895 lines) Patch
M content/content_renderer.gypi View 1 2 chunks +6 lines, -6 lines 0 comments Download
M content/content_tests.gypi View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/renderer_webkitplatformsupport_impl.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
A content/renderer/webcrypto/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
A + content/renderer/webcrypto/webcrypto_impl.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + content/renderer/webcrypto/webcrypto_impl.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
A + content/renderer/webcrypto/webcrypto_impl_nss.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
A + content/renderer/webcrypto/webcrypto_impl_openssl.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
A + content/renderer/webcrypto/webcrypto_impl_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
D content/renderer/webcrypto_impl.h View 1 2 1 chunk +0 lines, -88 lines 0 comments Download
D content/renderer/webcrypto_impl.cc View 1 2 1 chunk +0 lines, -96 lines 0 comments Download
D content/renderer/webcrypto_impl_nss.cc View 1 2 1 chunk +0 lines, -287 lines 0 comments Download
D content/renderer/webcrypto_impl_openssl.cc View 1 2 1 chunk +0 lines, -59 lines 0 comments Download
D content/renderer/webcrypto_impl_unittest.cc View 1 2 1 chunk +0 lines, -353 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
eroman
This should reduce the number of code reviews we are making jamesr do :)
7 years, 2 months ago (2013-09-25 22:30:34 UTC) #1
jamesr
lgtm I would like to take a look at the blink API interactions, but me ...
7 years, 2 months ago (2013-09-25 22:40:17 UTC) #2
eroman
BTW do you have a preference if this change uses a subdirectory versus per-file OWNERS ...
7 years, 2 months ago (2013-09-25 22:43:18 UTC) #3
jamesr
I think subdirs are easier for things like this - per-file OWNERS are really hard ...
7 years, 2 months ago (2013-09-25 23:11:09 UTC) #4
eroman
+jochen for content_tests.gypi approval
7 years, 2 months ago (2013-09-26 18:29:27 UTC) #5
jochen (gone - plz use gerrit)
lgtm
7 years, 2 months ago (2013-09-26 20:15:59 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eroman@chromium.org/24494003/29001
7 years, 2 months ago (2013-09-26 22:44:09 UTC) #7
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) content_browsertests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=159248
7 years, 2 months ago (2013-09-27 01:20:10 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eroman@chromium.org/24494003/29001
7 years, 2 months ago (2013-09-27 01:31:02 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eroman@chromium.org/24494003/64001
7 years, 2 months ago (2013-09-27 04:58:27 UTC) #10
eroman
7 years, 2 months ago (2013-09-27 05:02:40 UTC) #11
Message was sent while issue was closed.
Committed patchset #4 manually as r225659 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698