Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: ios/web/js_compile.gni

Issue 2449333002: [ios] Pass more --jscomp_error switches to the closure Compiler. (Closed)
Patch Set: Added back @public Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/translate/ios/browser/resources/translate_ios.js ('k') | ios/web/web_state/js/resources/base.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/web/js_compile.gni
diff --git a/ios/web/js_compile.gni b/ios/web/js_compile.gni
index eff527412e4328b3d4dd2ceec9db41270220a1cd..320b9f2ccab344f65e3893e56fb3dc3e3b22ce29 100644
--- a/ios/web/js_compile.gni
+++ b/ios/web/js_compile.gni
@@ -113,15 +113,13 @@ template("js_compile_checked") {
"$target_gen_dir/{{source_file_part}}",
]
- # TODO(crbug.com/487804): need to enable the following compilation checks
- # once the corresponding errors have been fixed:
- # --jscomp_error=checkTypes
- # --jscomp_error=checkVars
- # --jscomp_error=missingProperties
- # --jscomp_error=undefinedVars
args = [
"--compilation_level",
"SIMPLE_OPTIMIZATIONS",
+ "--jscomp_error=checkTypes",
+ "--jscomp_error=checkVars",
+ "--jscomp_error=missingProperties",
+ "--jscomp_error=undefinedVars",
"--jscomp_error=accessControls",
"--jscomp_error=ambiguousFunctionDecl",
"--jscomp_error=constantProperty",
« no previous file with comments | « components/translate/ios/browser/resources/translate_ios.js ('k') | ios/web/web_state/js/resources/base.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698