Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(465)

Unified Diff: ios/web/web_state/js/resources/message.js

Issue 2449333002: [ios] Pass more --jscomp_error switches to the closure Compiler. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/web/web_state/js/resources/message.js
diff --git a/ios/web/web_state/js/resources/message.js b/ios/web/web_state/js/resources/message.js
index 1649a64e98de39008a18df015a63653fffcf2b3e..a9cd29b3b0d1f98f6389085ea7bab955baa4f2d9 100644
--- a/ios/web/web_state/js/resources/message.js
+++ b/ios/web/web_state/js/resources/message.js
@@ -35,7 +35,7 @@ __gCrWeb.message = {};
/**
* Invokes a command on the Objective-C side.
* @param {Object} command The command in a JavaScript object.
- * @private
+ * @public
dpapad 2016/10/26 17:05:24 No need for @public. I don't even think such an an
Eugene But (OOO till 7-30) 2016/10/26 17:54:45 Done.
Justin Donnelly 2016/10/26 21:06:52 If you prefer not to use it for stylistic reasons,
Eugene But (OOO till 7-30) 2016/10/26 21:16:23 Thanks! I would prefer to use @public if it's a re
Eugene But (OOO till 7-30) 2016/10/27 23:23:21 Added @public back.
*/
__gCrWeb.message.invokeOnHost = function(command) {
messageQueue_.queue.push(command);
@@ -74,7 +74,7 @@ __gCrWeb.message = {};
queueObject.queue.forEach(function(command) {
var stringifiedMessage = __gCrWeb.common.JSONStringify({
"crwCommand": command,
- "crwWindowId": __gCrWeb.windowId
+ "crwWindowId": __gCrWeb['windowId']
});
// A web page can override |window.webkit| with any value. Deleting the
// object ensures that original and working implementation of

Powered by Google App Engine
This is Rietveld 408576698