[ios] Pass more --jscomp_error switches to the closure Compiler.

components/autofill/ios/browser/resources/autofill_controller.js

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-// Installs Autofill management functions on the |__gCrWeb| object.
-//
-// It scans the DOM, extracting and storing forms and returns a JSON string
-// representing an array of objects, each of which represents an Autofill form
-// with information about a form to be filled and/or submitted and it can be
-// translated to struct FormData
-// (chromium/src/components/autofill/core/common/form_data.h) for further
-// processing.
+/**
+  * @fileoverview Installs Autofill management functions on the __gCrWeb object.
+  *
+  * It scans the DOM, extracting and storing forms and returns a JSON string
+  * representing an array of objects, each of which represents an Autofill form
+  * with information about a form to be filled and/or submitted and it can be
+  * translated to struct FormData
+  * (chromium/src/components/autofill/core/common/form_data.h) for further
+  * processing.
+
+  * TODO(crbug.com/647084): Enable checkTypes error for this file.
+  * @suppress {checkTypes}
+  */
 
 /** @typedef {HTMLInputElement|HTMLTextAreaElement|HTMLSelectElement} */
 var FormControlElement;
 
 /**
   * @typedef {{
   *   name: string,
   *   value: string,
   *   form_control_type: string,
   *   autocomplete_attributes: string,
@@ skipping 20 matching lines @@
   */
 var AutofillFormData;
 
 /* Beginning of anonymous object. */
 (function() {
 
 /**
  * Namespace for this file. It depends on |__gCrWeb| having already been
  * injected.
  */
-__gCrWeb['autofill'] = {};
+__gCrWeb.autofill = {};
+__gCrWeb['autofill'] = __gCrWeb.autofill;

[dpapad, 2016/10/26 17:05:24]

What does this line do? Seems unnecessary at first glance (sets the |autofill|
property to itself?)

Same question for similar pattern in other files in this CL.

[Eugene But (OOO till 7-30), 2016/10/26 17:54:45]

Stores autofill namespace object in a global __gCrWeb referenced by a string, so
it does not get renamed by closure compiler during the minification. Previous
line is necessary to tell Closure that __gCrWeb.autofill property actually
exists. Added comments.

dbeam@ suggested to follow | window['displayNoteTitle'] = displayNoteTitle;|
approach from this doc:
https://developers.google.com/closure/compiler/docs/api-tutorial3#export
hopefully I understood it correctly :)

[dpapad, 2016/10/26 18:18:35]

Ah ok, it makes sense now. I am used to seeing goog.exportSymbol() calls to do
that, but you are not using Closure library here, just Closure compiler, so this
is OK.

 
 /**
  * The maximum length allowed for form data.
  *
  * This variable is from AutofillTable::kMaxDataLength in
  * chromium/src/components/autofill/core/browser/webdata/autofill_table.h
  *
  * @const {number}
  */
 __gCrWeb.autofill.MAX_DATA_LENGTH = 1024;
@@ skipping 1996 matching lines @@
       var elementName = __gCrWeb['common'].nameForAutofill(element);
       var value = formData[elementName];
       if (value) {
         element.placeholder = value;
       }
     }
   }
 };
 
 }());  // End of anonymous object