Chromium Code Reviews| Index: tools/metrics/histograms/histograms.xml |
| diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml |
| index 4a482cf89b505cf6754ebb909ee735c14b1d73cf..c905bffa6295a425b872b11f6f34fa157682858d 100644 |
| --- a/tools/metrics/histograms/histograms.xml |
| +++ b/tools/metrics/histograms/histograms.xml |
| @@ -13971,6 +13971,18 @@ Therefore, the affected-histogram name has to have at least one dot in it. |
| <summary>The time spent in closesocket call in UDPSocketWin::Close.</summary> |
| </histogram> |
| +<histogram name="Net.WebSocket.DeflateMode" |
| + enum="WebSocketNewPerMessageDeflateContextTakeoverMode"> |
| + <owner>yhirano@chromium.org</owner> |
| + <owner>ricea@chromium.org</owner> |
| + <owner>tyoshino@chromium.org</owner> |
| + <summary> |
| + Count the number of WebSockets that accepted permessage-deflate extension |
| + for each context take over mode. Used by the new Chromium-based WebSocket |
| + implementation. |
| + </summary> |
| +</histogram> |
| + |
| <histogram name="Net.WebSocket.HandshakeResult" |
| enum="WebSocketNewHandshakeResult"> |
| <owner>yhirano@chromium.org</owner> |
| @@ -29732,10 +29744,13 @@ Therefore, the affected-histogram name has to have at least one dot in it. |
| <histogram name="WebCore.WebSocket.PerMessageDeflateContextTakeOverMode" |
| enum="WebSocketPerMessageDeflateContextTakeOverMode"> |
| - <owner>Please list the metric's owners. Add more owner tags as needed.</owner> |
| + <owner>yhirano@chromium.org</owner> |
| + <owner>ricea@chromium.org</owner> |
| + <owner>tyoshino@chromium.org</owner> |
| <summary> |
| Count the number of WebSockets that accepted permessage-deflate extension |
| - for each context take over mode. |
| + for each context take over mode. Used by the old Blink-based WebSocket |
| + implementation. |
| </summary> |
| </histogram> |
| @@ -42109,6 +42124,11 @@ Therefore, the affected-histogram name has to have at least one dot in it. |
| <int value="2" label="FAILED">Failed</int> |
| </enum> |
| +<enum name="WebSocketNewPerMessageDeflateContextTakeoverMode" type="int"> |
| + <int value="0" label="DO_NOT_TAKE_OVER_CONTEXT"/> |
|
Alexei Svitkine (slow)
2014/04/23 13:23:18
Optional nit: These are shown to humans on the das
tyoshino (SeeGerritForStatus)
2014/04/24 10:38:15
Oh, got it. Done here and the enum right below too
|
| + <int value="1" label="TAKE_OVER_CONTEXT"/> |
| +</enum> |
| + |
| <enum name="WebSocketPerMessageDeflateContextTakeOverMode" type="int"> |
| <int value="0" label="DoNotTakeOverContext"/> |
| <int value="1" label="TakeOverContext"/> |