UMA: Add Net.WebSocket.DeflateMode

UMA: Add Net.WebSocket.DeflateMode

Counts the number of successful handshake completion with
permessage-deflate enabled for each negotiated context_takeover
parameter value.

BUG=128156, 359926
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266444

[Adam Rice, 2014-04-21 09:29:10]

I think you are supposed to include the change to histograms.xml in the same CL.

[tyoshino (SeeGerritForStatus), 2014-04-22 02:12:09]

On 2014/04/21 09:29:10, Adam Rice wrote:
> I think you are supposed to include the change to histograms.xml in the same
CL.

Done

[yhirano, 2014-04-22 02:15:12]

lgtm

[Adam Rice, 2014-04-22 02:20:50]

lgtm

[tyoshino (SeeGerritForStatus), 2014-04-23 03:52:45]

+asvitkine for histograms.xml

[Alexei Svitkine (slow), 2014-04-23 13:23:17]

lgtm

https://codereview.chromium.org/244933003/diff/20001/net/websockets/websocket...
File net/websockets/websocket_deflater.h (right):

https://codereview.chromium.org/244933003/diff/20001/net/websockets/websocket...
net/websockets/websocket_deflater.h:24: enum ContextTakeOverMode {
Nit: Add a comment mentioning not to re-order or remove entries since this enum
is used in UMA.

https://codereview.chromium.org/244933003/diff/20001/tools/metrics/histograms...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/244933003/diff/20001/tools/metrics/histograms...
tools/metrics/histograms/histograms.xml:42128: +  <int value="0"
label="DO_NOT_TAKE_OVER_CONTEXT"/>
Optional nit: These are shown to humans on the dashboard, so consider giving a
more human-readable/descriptive names.

[tyoshino (SeeGerritForStatus), 2014-04-24 10:38:15]

Thanks

https://codereview.chromium.org/244933003/diff/20001/net/websockets/websocket...
File net/websockets/websocket_deflater.h (right):

https://codereview.chromium.org/244933003/diff/20001/net/websockets/websocket...
net/websockets/websocket_deflater.h:24: enum ContextTakeOverMode {
On 2014/04/23 13:23:18, Alexei Svitkine wrote:
> Nit: Add a comment mentioning not to re-order or remove entries since this
enum
> is used in UMA.

Done.

https://codereview.chromium.org/244933003/diff/20001/tools/metrics/histograms...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/244933003/diff/20001/tools/metrics/histograms...
tools/metrics/histograms/histograms.xml:42128: +  <int value="0"
label="DO_NOT_TAKE_OVER_CONTEXT"/>
On 2014/04/23 13:23:18, Alexei Svitkine wrote:
> Optional nit: These are shown to humans on the dashboard, so consider giving a
> more human-readable/descriptive names.

Oh, got it. Done here and the enum right below too.

[tyoshino (SeeGerritForStatus), 2014-04-24 10:38:23]

The CQ bit was checked by tyoshino@chromium.org

[commit-bot: I haz the power, 2014-04-24 11:07:29]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tyoshino@chromium.org/244933003/60001

[commit-bot: I haz the power, 2014-04-24 14:18:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-24 14:18:32]

Try jobs failed on following builders:
  tryserver.chromium on linux_chromium_chromeos_rel

[tyoshino (SeeGerritForStatus), 2014-04-28 04:47:43]

The CQ bit was checked by tyoshino@chromium.org

[commit-bot: I haz the power, 2014-04-28 04:49:32]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tyoshino@chromium.org/244933003/60001

[commit-bot: I haz the power, 2014-04-28 06:40:17]

Change committed as 266444