Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(608)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 24493003: Factor out ServerThread from the QUIC EndToEndTest in order to reuse in (Closed)

Created:
7 years, 2 months ago by Ryan Hamilton
Modified:
7 years, 2 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org
Visibility:
Public.

Description

Factor out ServerThread from the QUIC EndToEndTest in order to reuse in a Chromium test. Merge internal change: 53205265 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=225309

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Cleanup #

Total comments: 6

Patch Set 4 : fix comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+153 lines, -87 lines) Patch
M net/net.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
M net/tools/quic/end_to_end_test.cc View 1 2 4 chunks +9 lines, -85 lines 0 comments Download
M net/tools/quic/quic_in_memory_cache.h View 2 chunks +10 lines, -2 lines 0 comments Download
M net/tools/quic/quic_in_memory_cache.cc View 2 chunks +31 lines, -0 lines 0 comments Download
A net/tools/quic/test_tools/server_thread.h View 1 2 3 1 chunk +48 lines, -0 lines 0 comments Download
A net/tools/quic/test_tools/server_thread.cc View 1 2 3 1 chunk +53 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Ryan Hamilton
7 years, 2 months ago (2013-09-25 03:56:05 UTC) #1
ramant (doing other things)
lgtm https://codereview.chromium.org/24493003/diff/6001/net/tools/quic/test_tools/server_thread.cc File net/tools/quic/test_tools/server_thread.cc (right): https://codereview.chromium.org/24493003/diff/6001/net/tools/quic/test_tools/server_thread.cc#newcode1 net/tools/quic/test_tools/server_thread.cc:1: // Copyright (c) 2012 The Chromium Authors. All ...
7 years, 2 months ago (2013-09-25 14:39:12 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rch@chromium.org/24493003/12001
7 years, 2 months ago (2013-09-25 14:51:09 UTC) #3
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 2 months ago (2013-09-25 15:41:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rch@chromium.org/24493003/12001
7 years, 2 months ago (2013-09-25 17:38:59 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rch@chromium.org/24493003/12001
7 years, 2 months ago (2013-09-25 21:52:27 UTC) #6
Ryan Hamilton
whoops, I never sent this https://codereview.chromium.org/24493003/diff/6001/net/tools/quic/test_tools/server_thread.cc File net/tools/quic/test_tools/server_thread.cc (right): https://codereview.chromium.org/24493003/diff/6001/net/tools/quic/test_tools/server_thread.cc#newcode1 net/tools/quic/test_tools/server_thread.cc:1: // Copyright (c) 2012 ...
7 years, 2 months ago (2013-09-25 23:29:36 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rch@chromium.org/24493003/12001
7 years, 2 months ago (2013-09-26 01:43:54 UTC) #8
commit-bot: I haz the power
7 years, 2 months ago (2013-09-26 03:46:46 UTC) #9
Message was sent while issue was closed. 
Change committed as 225309

Powered by Google App Engine
This is Rietveld 408576698