Fix some bool/int mismatches.

Fix some bool/int mismatches.

Found by winxfa bot when fx_bool defined to bool.

Committed: https://pdfium.googlesource.com/pdfium/+/16b703cb504abedbae3e14f69c1ae355363a7ad8

[Tom Sepez, 2016-10-25 22:51:30]

tsepez@chromium.org changed reviewers:
+ npm@chromium.org

[Tom Sepez, 2016-10-25 22:51:31]

npm, for review.  See
https://build.chromium.org/p/tryserver.client.pdfium/builders/win_xfa/builds/...

[Tom Sepez, 2016-10-25 22:51:57]

Description was changed from

==========
Fix some bool/int mismatches.
==========

to

==========
Fix some bool/int mismatches.

Found by winxfa bot when fx_bool defined to bool.
==========

[Tom Sepez, 2016-10-25 22:53:25]

The CQ bit was checked by tsepez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-25 22:53:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-25 23:06:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-25 23:06:59]

Dry run: This issue passed the CQ dry run.

[Tom Sepez, 2016-10-25 23:08:45]

https://codereview.chromium.org/2449293002/diff/1/fpdfsdk/fpdfxfa/cpdfxfa_doc...
File fpdfsdk/fpdfxfa/cpdfxfa_docenvironment.cpp (left):

https://codereview.chromium.org/2449293002/diff/1/fpdfsdk/fpdfxfa/cpdfxfa_doc...
fpdfsdk/fpdfxfa/cpdfxfa_docenvironment.cpp:922: FPDF_BOOL bRet = TRUE;
note: they mean FX_BOOL, not the other kind.

[npm, 2016-10-26 14:33:00]

lgtm

https://codereview.chromium.org/2449293002/diff/1/core/fpdfapi/render/fpdf_re...
File core/fpdfapi/render/fpdf_render_loadimage.cpp (right):

https://codereview.chromium.org/2449293002/diff/1/core/fpdfapi/render/fpdf_re...
core/fpdfapi/render/fpdf_render_loadimage.cpp:554: !pParams ||
pParams->GetIntegerFor("ColorTransform", 1)));
Not quite sure why this change will make any difference. Will this work with:
!!pParams->GetIntegerFor(...)?

https://codereview.chromium.org/2449293002/diff/1/fpdfsdk/fpdfxfa/cpdfxfa_doc...
File fpdfsdk/fpdfxfa/cpdfxfa_docenvironment.cpp (left):

https://codereview.chromium.org/2449293002/diff/1/fpdfsdk/fpdfxfa/cpdfxfa_doc...
fpdfsdk/fpdfxfa/cpdfxfa_docenvironment.cpp:922: FPDF_BOOL bRet = TRUE;
On 2016/10/25 23:08:45, Tom Sepez wrote:
> note: they mean FX_BOOL, not the other kind.

Aren't they both the same (int)?

[Tom Sepez, 2016-10-26 15:45:09]

https://codereview.chromium.org/2449293002/diff/1/core/fpdfapi/render/fpdf_re...
File core/fpdfapi/render/fpdf_render_loadimage.cpp (right):

https://codereview.chromium.org/2449293002/diff/1/core/fpdfapi/render/fpdf_re...
core/fpdfapi/render/fpdf_render_loadimage.cpp:554: !pParams ||
pParams->GetIntegerFor("ColorTransform", 1)));
On 2016/10/26 14:33:00, npm wrote:
> Not quite sure why this change will make any difference. Will this work with:
> !!pParams->GetIntegerFor(...)?

Because in c++ the || operator yields a bool.  If it weren't there, we'd need to
be explicit with the !!.

https://codereview.chromium.org/2449293002/diff/1/fpdfsdk/fpdfxfa/cpdfxfa_doc...
File fpdfsdk/fpdfxfa/cpdfxfa_docenvironment.cpp (left):

https://codereview.chromium.org/2449293002/diff/1/fpdfsdk/fpdfxfa/cpdfxfa_doc...
fpdfsdk/fpdfxfa/cpdfxfa_docenvironment.cpp:922: FPDF_BOOL bRet = TRUE;
On 2016/10/26 14:33:00, npm wrote:
> On 2016/10/25 23:08:45, Tom Sepez wrote:
> > note: they mean FX_BOOL, not the other kind.
> 
> Aren't they both the same (int)?

Yes, and that would be an obstacle to converting FX_BOOL to bool.

[Tom Sepez, 2016-10-26 15:45:14]

The CQ bit was checked by tsepez@chromium.org

[commit-bot: I haz the power, 2016-10-26 15:45:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-26 15:45:35]

Description was changed from

==========
Fix some bool/int mismatches.

Found by winxfa bot when fx_bool defined to bool.
==========

to

==========
Fix some bool/int mismatches.

Found by winxfa bot when fx_bool defined to bool.

Committed:
https://pdfium.googlesource.com/pdfium/+/16b703cb504abedbae3e14f69c1ae355363a...
==========

[commit-bot: I haz the power, 2016-10-26 15:45:36]

Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/16b703cb504abedbae3e14f69c1ae355363a...