Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(746)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Unified Diff: chrome/browser/ui/libgtkui/OWNERS
Issue
2449243002
:
Gtk3 ui: Add libgtk3ui as a separate build component (Closed)
Patch Set: Add theme_properties dep to //chrome/browser/ui
Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Jump to:
build/config/linux/gtk2/BUILD.gn
build/config/linux/gtk3/BUILD.gn
chrome/browser/BUILD.gn
chrome/browser/ui/BUILD.gn
chrome/browser/ui/libgtk2ui/BUILD.gn
chrome/browser/ui/libgtk2ui/OWNERS
chrome/browser/ui/libgtk2ui/app_indicator_icon.h
chrome/browser/ui/libgtk2ui/app_indicator_icon.cc
chrome/browser/ui/libgtk2ui/app_indicator_icon_menu.h
chrome/browser/ui/libgtk2ui/app_indicator_icon_menu.cc
chrome/browser/ui/libgtk2ui/chrome_gtk_frame.h
chrome/browser/ui/libgtk2ui/chrome_gtk_frame.cc
chrome/browser/ui/libgtk2ui/chrome_gtk_menu_subclasses.h
chrome/browser/ui/libgtk2ui/chrome_gtk_menu_subclasses.cc
chrome/browser/ui/libgtk2ui/gconf_listener.h
chrome/browser/ui/libgtk2ui/gconf_listener.cc
chrome/browser/ui/libgtk2ui/gtk2_event_loop.h
chrome/browser/ui/libgtk2ui/gtk2_event_loop.cc
chrome/browser/ui/libgtk2ui/gtk2_key_bindings_handler.h
chrome/browser/ui/libgtk2ui/gtk2_key_bindings_handler.cc
chrome/browser/ui/libgtk2ui/gtk2_signal.h
chrome/browser/ui/libgtk2ui/gtk2_status_icon.h
chrome/browser/ui/libgtk2ui/gtk2_status_icon.cc
chrome/browser/ui/libgtk2ui/gtk2_ui.h
chrome/browser/ui/libgtk2ui/gtk2_ui.cc
chrome/browser/ui/libgtk2ui/gtk2_util.h
chrome/browser/ui/libgtk2ui/gtk2_util.cc
chrome/browser/ui/libgtk2ui/libgtk2ui_export.h
chrome/browser/ui/libgtk2ui/menu_util.h
chrome/browser/ui/libgtk2ui/menu_util.cc
chrome/browser/ui/libgtk2ui/native_theme_gtk2.h
chrome/browser/ui/libgtk2ui/native_theme_gtk2.cc
chrome/browser/ui/libgtk2ui/print_dialog_gtk2.h
chrome/browser/ui/libgtk2ui/print_dialog_gtk2.cc
chrome/browser/ui/libgtk2ui/printing_gtk2_util.h
chrome/browser/ui/libgtk2ui/printing_gtk2_util.cc
chrome/browser/ui/libgtk2ui/select_file_dialog_impl.h
chrome/browser/ui/libgtk2ui/select_file_dialog_impl.cc
chrome/browser/ui/libgtk2ui/select_file_dialog_impl_gtk2.h
chrome/browser/ui/libgtk2ui/select_file_dialog_impl_gtk2.cc
chrome/browser/ui/libgtk2ui/select_file_dialog_impl_kde.cc
chrome/browser/ui/libgtk2ui/select_file_dialog_interactive_uitest.cc
chrome/browser/ui/libgtk2ui/skia_utils_gtk2.h
chrome/browser/ui/libgtk2ui/skia_utils_gtk2.cc
chrome/browser/ui/libgtk2ui/unity_service.h
chrome/browser/ui/libgtk2ui/unity_service.cc
chrome/browser/ui/libgtk2ui/x11_input_method_context_impl_gtk2.h
chrome/browser/ui/libgtk2ui/x11_input_method_context_impl_gtk2.cc
chrome/browser/ui/libgtkui/BUILD.gn
chrome/browser/ui/libgtkui/OWNERS
chrome/browser/ui/libgtkui/app_indicator_icon.h
chrome/browser/ui/libgtkui/app_indicator_icon.cc
chrome/browser/ui/libgtkui/app_indicator_icon_menu.h
chrome/browser/ui/libgtkui/app_indicator_icon_menu.cc
chrome/browser/ui/libgtkui/chrome_gtk_frame.h
chrome/browser/ui/libgtkui/chrome_gtk_frame.cc
chrome/browser/ui/libgtkui/chrome_gtk_menu_subclasses.h
chrome/browser/ui/libgtkui/chrome_gtk_menu_subclasses.cc
chrome/browser/ui/libgtkui/gconf_listener.h
chrome/browser/ui/libgtkui/gconf_listener.cc
chrome/browser/ui/libgtkui/gtk2_event_loop.h
chrome/browser/ui/libgtkui/gtk2_event_loop.cc
chrome/browser/ui/libgtkui/gtk2_key_bindings_handler.h
chrome/browser/ui/libgtkui/gtk2_key_bindings_handler.cc
chrome/browser/ui/libgtkui/gtk2_signal.h
chrome/browser/ui/libgtkui/gtk2_status_icon.h
chrome/browser/ui/libgtkui/gtk2_status_icon.cc
chrome/browser/ui/libgtkui/gtk2_ui.h
chrome/browser/ui/libgtkui/gtk2_ui.cc
chrome/browser/ui/libgtkui/gtk2_util.h
chrome/browser/ui/libgtkui/gtk2_util.cc
chrome/browser/ui/libgtkui/libgtkui_export.h
chrome/browser/ui/libgtkui/menu_util.h
chrome/browser/ui/libgtkui/menu_util.cc
chrome/browser/ui/libgtkui/native_theme_gtk2.h
chrome/browser/ui/libgtkui/native_theme_gtk2.cc
chrome/browser/ui/libgtkui/print_dialog_gtk2.h
chrome/browser/ui/libgtkui/print_dialog_gtk2.cc
chrome/browser/ui/libgtkui/printing_gtk2_util.h
chrome/browser/ui/libgtkui/printing_gtk2_util.cc
chrome/browser/ui/libgtkui/select_file_dialog_impl.h
chrome/browser/ui/libgtkui/select_file_dialog_impl.cc
chrome/browser/ui/libgtkui/select_file_dialog_impl_gtk2.h
chrome/browser/ui/libgtkui/select_file_dialog_impl_gtk2.cc
chrome/browser/ui/libgtkui/select_file_dialog_impl_kde.cc
chrome/browser/ui/libgtkui/select_file_dialog_interactive_uitest.cc
chrome/browser/ui/libgtkui/skia_utils_gtk2.h
chrome/browser/ui/libgtkui/skia_utils_gtk2.cc
chrome/browser/ui/libgtkui/unity_service.h
chrome/browser/ui/libgtkui/unity_service.cc
chrome/browser/ui/libgtkui/x11_input_method_context_impl_gtk2.h
chrome/browser/ui/libgtkui/x11_input_method_context_impl_gtk2.cc
chrome/browser/ui/views/chrome_browser_main_extra_parts_views_linux.cc
chrome/test/BUILD.gn
third_party/harfbuzz-ng/BUILD.gn
View side-by-side diff with in-line comments
Download patch
« no previous file with comments
|
« chrome/browser/ui/libgtkui/BUILD.gn
('k') |
chrome/browser/ui/libgtkui/app_indicator_icon.h »
('j') |
no next file with comments »
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
Index: chrome/browser/ui/libgtkui/OWNERS
diff --git a/chrome/browser/ui/libgtk2ui/OWNERS b/chrome/browser/ui/libgtkui/OWNERS
similarity index 100%
rename from chrome/browser/ui/libgtk2ui/OWNERS
rename to chrome/browser/ui/libgtkui/OWNERS
« no previous file with comments
|
« chrome/browser/ui/libgtkui/BUILD.gn
('k') |
chrome/browser/ui/libgtkui/app_indicator_icon.h »
('j') |
no next file with comments »
Issue 2449243002: Gtk3 ui: Add libgtk3ui as a separate build component (Closed)
Created 4 years, 2 months ago by Tom (Use chromium acct)
Modified 4 years, 2 months ago
Reviewers: Elliot Glaysher, Dirk Pranke, sky
Base URL:
Comments: 21
This is Rietveld
408576698