Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4385)

Unified Diff: chrome/browser/ui/BUILD.gn

Issue 2449243002: Gtk3 ui: Add libgtk3ui as a separate build component (Closed)
Patch Set: Add theme_properties dep to //chrome/browser/ui Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/BUILD.gn ('k') | chrome/browser/ui/libgtk2ui/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/BUILD.gn
diff --git a/chrome/browser/ui/BUILD.gn b/chrome/browser/ui/BUILD.gn
index 97d00e08b8ce1d6be50fe101c2ab361a4a58c71e..938acba79d8ee1456d9a9471a3814a8a1ad53191 100644
--- a/chrome/browser/ui/BUILD.gn
+++ b/chrome/browser/ui/BUILD.gn
@@ -1891,11 +1891,12 @@ split_static_library("ui") {
deps += [ "//build/linux/libgio" ]
}
if (use_aura && !use_ozone && is_desktop_linux) {
- deps += [
- # gtk2 is the only component that can interact with gtk2 in our new
- # world.
- "//chrome/browser/ui/libgtk2ui",
- ]
+ # These are the only components that can interact with gtk.
+ if (use_gtk3) {
+ deps += [ "//chrome/browser/ui/libgtkui:libgtk3ui" ]
+ } else {
+ deps += [ "//chrome/browser/ui/libgtkui:libgtk2ui" ]
+ }
}
if (is_win || is_mac || is_desktop_linux) {
sources += [
@@ -2073,6 +2074,7 @@ split_static_library("ui") {
"webui/theme_source.cc",
"webui/theme_source.h",
]
+ deps += [ "//chrome/browser:theme_properties" ]
}
if (enable_print_preview) {
sources += [
« no previous file with comments | « chrome/browser/BUILD.gn ('k') | chrome/browser/ui/libgtk2ui/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698