Gtk3 ui: Add libgtk3ui as a separate build component

chrome/browser/ui/BUILD.gn

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//build/config/chromecast_build.gni")
 import("//build/config/crypto.gni")
 import("//build/config/features.gni")
 import("//build/config/ui.gni")
 import("//build/split_static_library.gni")
 import("//chrome/common/features.gni")
@@ skipping 1873 matching lines @@
         "views/frame/web_app_left_header_view_ash.cc",
         "views/frame/web_app_left_header_view_ash.h",
         "views/tabs/window_finder_ash.cc",
       ]
     }
   }
   if (use_gio) {
     deps += [ "//build/linux/libgio" ]
   }
   if (use_aura && !use_ozone && is_desktop_linux) {
-    deps += [
-      # gtk2 is the only component that can interact with gtk2 in our new
-      # world.
-      "//chrome/browser/ui/libgtk2ui",
-    ]
+    # gtk{2,3} is the only component that can interact with gtk in our new
+    # world.

[Dirk Pranke, 2016/10/25 23:56:10]

Nit: I'd rewrite this to "these are the only components that can interact with
gtk".

[Tom (Use chromium acct), 2016/10/26 18:20:01]

Done.

+    if (use_gtk3) {
+      deps += [ "//chrome/browser/ui/libgtk2ui:libgtk3ui" ]
+    } else {
+      deps += [ "//chrome/browser/ui/libgtk2ui:libgtk2ui" ]
+    }

[Dirk Pranke, 2016/10/25 23:56:10]

You eventually want to be building and depending on both, right? Because if you
don't want that, we should structure the targets a bit differently.

[Tom (Use chromium acct), 2016/10/26 18:20:01]

We'll want to build both during our gtk3 transition, but I think after that is
over, we would only need to build the gtk3 version.

   }
   if (is_win || is_mac || is_desktop_linux) {
     sources += [
       "avatar_button_error_controller.cc",
       "avatar_button_error_controller.h",
       "avatar_button_error_controller_delegate.h",
       "startup/default_browser_infobar_delegate.cc",
       "startup/default_browser_infobar_delegate.h",
       "startup/default_browser_prompt.cc",
       "startup/default_browser_prompt.h",
@@ skipping 1511 matching lines @@
       "test/test_confirm_bubble_model.cc",
       "test/test_confirm_bubble_model.h",
     ]
     deps += [ "//chrome/test:test_support_ui" ]
   }
 
   if (enable_extensions) {
     deps += [ "//extensions/browser" ]
   }
 }