Add suborigins to WebSecurityOrigin

Add suborigins to WebSecurityOrigin

Suborigins were not passed through conversions from SecurityOrigin ->
WebSecurityOrigin, and also not from url::Origin -> WebSecurityOrigin.
This CL adds support to make sure they are added to WebSecurityOrigin
from their respective origination points, and it also adds accessors to
WebSecurityOrigin to get the suborigin value.

BUG=658992
Committed: https://crrev.com/908428c015af7f9aac62b6377809191d5677ce12
Cr-Commit-Position: refs/heads/master@{#427828}

[jww, 2016-10-25 21:22:12]

jww@chromium.org changed reviewers:
+ csharrison@chromium.org, mkwst@chromium.org

[jww, 2016-10-25 21:22:12]

Hi folks. Can you take a look at this? I believe it should fix
https://crbug.com/658992 and allow csharrison's CL to go through.

Mike, one notable change is that in
Source/platform/weborigin/SecurityOrigin.cpp, I removed the restriction on
Suborigns being enabled in order for deserializeSuboriginAndProtocolAndHost() to
do its parsing. This is to allow testing to work (such as the changes in
content/child/blink_platform_impl_unittest.cc), and I don't think it has an
material affect for embedders, since enforceSuborigin in
Source/core/dom/SecurityContext.cpp still gates enforcement on suborigins being
enabled. (This also matches how url::Origin behaves, since it is not gated on
suborigins being enabled either.)

[Charlie Harrison, 2016-10-25 21:23:41]

Thanks for tackling this so quickly. I'll try to review this tomorrow.

[jww, 2016-10-25 21:26:07]

On 2016/10/25 21:23:41, Charlie Harrison wrote:
> Thanks for tackling this so quickly. I'll try to review this tomorrow.

Sounds good! Just an FYI that tomorrow is my last day for the year as I'll be
heading out on paternity leave, so if we're not able to wrap it up by then, you
may need to take over from there.

[Charlie Harrison, 2016-10-25 21:28:41]

On 2016/10/25 21:26:07, jww wrote:
> On 2016/10/25 21:23:41, Charlie Harrison wrote:
> > Thanks for tackling this so quickly. I'll try to review this tomorrow.
> 
> Sounds good! Just an FYI that tomorrow is my last day for the year as I'll be
> heading out on paternity leave, so if we're not able to wrap it up by then,
you
> may need to take over from there.

Thanks for the heads up. I'll see what I can do, but I'm also happy to take
ownership if we don't get this done in time. There is no big rush to land the
dependent CL.

[Charlie Harrison, 2016-10-26 00:29:07]

non owner LGTM, thanks again.

[Charlie Harrison, 2016-10-26 00:38:56]

For some reason I assumed dry-run already passed... let's do a dry run.

[Charlie Harrison, 2016-10-26 00:39:04]

The CQ bit was checked by csharrison@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-26 00:39:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-26 02:48:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-26 02:48:20]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[jww, 2016-10-26 02:50:29]

The CQ bit was checked by jww@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-26 02:50:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-26 04:32:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-26 04:32:41]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Mike West, 2016-10-26 08:22:23]

Thanks!

https://codereview.chromium.org/2449233002/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/weborigin/SecurityOrigin.cpp (right):

https://codereview.chromium.org/2449233002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/weborigin/SecurityOrigin.cpp:135: }
Nit: No {} for single-line clause.

https://codereview.chromium.org/2449233002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/weborigin/SecurityOrigin.cpp:537: const
String& suborigin) {
LGTM if you add specific tests for this new constructor.

[Mike West, 2016-10-26 08:23:13]

mkwst@chromium.org changed reviewers:
+ jochen@chromium.org

[Mike West, 2016-10-26 08:23:14]

Perhaps jochen@ can stamp //content/child for you?

[jochen (gone - plz use gerrit), 2016-10-26 08:25:18]

lgtm

[jww, 2016-10-26 16:53:00]

https://codereview.chromium.org/2449233002/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/weborigin/SecurityOrigin.cpp (right):

https://codereview.chromium.org/2449233002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/weborigin/SecurityOrigin.cpp:135: }
On 2016/10/26 08:22:23, Mike West wrote:
> Nit: No {} for single-line clause.

Done.

https://codereview.chromium.org/2449233002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/weborigin/SecurityOrigin.cpp:537: const
String& suborigin) {
On 2016/10/26 08:22:23, Mike West wrote:
> LGTM if you add specific tests for this new constructor.

Done.

[jww, 2016-10-26 16:53:05]

The CQ bit was checked by jww@chromium.org

[jww, 2016-10-26 16:53:06]

The patchset sent to the CQ was uploaded after l-g-t-m from jochen@chromium.org,
mkwst@chromium.org, csharrison@chromium.org
Link to the patchset: https://codereview.chromium.org/2449233002/#ps40001
(title: "Rebase on ToT")

[commit-bot: I haz the power, 2016-10-26 16:53:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-26 21:52:23]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-10-26 21:54:10]

Description was changed from

==========
Add suborigins to WebSecurityOrigin

Suborigins were not passed through conversions from SecurityOrigin ->
WebSecurityOrigin, and also not from url::Origin -> WebSecurityOrigin.
This CL adds support to make sure they are added to WebSecurityOrigin
from their respective origination points, and it also adds accessors to
WebSecurityOrigin to get the suborigin value.

BUG=658992
==========

to

==========
Add suborigins to WebSecurityOrigin

Suborigins were not passed through conversions from SecurityOrigin ->
WebSecurityOrigin, and also not from url::Origin -> WebSecurityOrigin.
This CL adds support to make sure they are added to WebSecurityOrigin
from their respective origination points, and it also adds accessors to
WebSecurityOrigin to get the suborigin value.

BUG=658992

Committed: https://crrev.com/908428c015af7f9aac62b6377809191d5677ce12
Cr-Commit-Position: refs/heads/master@{#427828}
==========

[commit-bot: I haz the power, 2016-10-26 21:54:11]

Patchset 3 (id:??) landed as
https://crrev.com/908428c015af7f9aac62b6377809191d5677ce12
Cr-Commit-Position: refs/heads/master@{#427828}