UMA: Count the number of WebSocket.send() call for each argument type.

UMA: Count the number of WebSocket.send() call for each argument type.

For the initial version, we just check distribution over all
connections. Not counts during each connection.

BUG=128156, 359926
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=172595

[tyoshino (SeeGerritForStatus), 2014-04-21 09:22:19]

+ricea

[Adam Rice, 2014-04-21 09:37:23]

I think it might be require less code if you added an argument to
handleSendResult() giving the WebSocketSendType, and then made the histogram
call from within handleSendResult().

What do you think?

[tyoshino (SeeGerritForStatus), 2014-04-22 03:24:31]

On 2014/04/21 09:37:23, Adam Rice wrote:
> I think it might be require less code if you added an argument to
> handleSendResult() giving the WebSocketSendType, and then made the histogram
> call from within handleSendResult().
> 
> What do you think?

Done

----

histograms.xml change
https://codereview.chromium.org/246573002/

[Adam Rice, 2014-04-22 03:55:49]

lgtm

[yhirano, 2014-04-22 08:04:16]

lgtm

[tyoshino (SeeGerritForStatus), 2014-04-25 06:01:32]

On 2014/04/22 08:04:16, yhirano wrote:
> lgtm

Used pywebsocket benchmark.html (local connection) to check if there's any
unacceptable performance degrade. It looks the impact is negligible.

w/ histograms

10	84979.253
50	145661.451
100	150810.015
500	147338.129
1000	129949.239
5000	110226.05
10000	102605.21
50000	84558.216
100000	88734.835

w/o histograms

10	86050.42
50	118931.475
100	105675.955
500	120046.893
1000	111304.348
5000	94727.105
10000	91184.328
50000	78829.869
100000	85333.333

[tyoshino (SeeGerritForStatus), 2014-04-25 06:07:38]

The CQ bit was checked by tyoshino@chromium.org

[commit-bot: I haz the power, 2014-04-25 06:08:01]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tyoshino@chromium.org/244923002/40001

[commit-bot: I haz the power, 2014-04-25 06:39:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-25 06:39:18]

Try jobs failed on following builders:
  tryserver.blink on linux_blink_rel

[tyoshino (SeeGerritForStatus), 2014-04-25 06:46:10]

The CQ bit was checked by tyoshino@chromium.org

[commit-bot: I haz the power, 2014-04-25 06:46:31]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tyoshino@chromium.org/244923002/40001

[commit-bot: I haz the power, 2014-04-25 07:21:52]

Change committed as 172595