Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(600)

Issue 2449223004: GN: Fix dart_bootstrap build (Closed)

Created:
4 years, 1 month ago by zra
Modified:
4 years, 1 month ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

GN: Fix dart_bootstrap build Makes sure we are using the no_snapshot variants of the libraries, that we get builtin.cc instead of builtin_nolib.cc, and that all of the right library sources get built in. fixes=27668 R=vegorov@google.com Committed: https://github.com/dart-lang/sdk/commit/e3f1794ba3888a0c13780e7dbf3dde93334b8128

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+127 lines, -61 lines) Patch
M runtime/bin/BUILD.gn View 11 chunks +127 lines, -61 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
zra
4 years, 1 month ago (2016-10-26 13:42:27 UTC) #2
zra
4 years, 1 month ago (2016-10-26 14:45:22 UTC) #4
Vyacheslav Egorov (Google)
lgtm
4 years, 1 month ago (2016-10-26 14:52:08 UTC) #5
zra
4 years, 1 month ago (2016-10-26 15:24:28 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e3f1794ba3888a0c13780e7dbf3dde93334b8128 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698