Chromium Code Reviews

Issue 2449223002: Overlay next_ and value_/string_ in AstValue/AstString (Closed)

Created:
4 years, 1 month ago by Toon Verwaest
Modified:
4 years, 1 month ago
Reviewers:
adamk
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Overlay next_ and value_/string_ in AstValue/AstString BUG= Committed: https://crrev.com/a16701598c029320bc0b3f60727a5fc148e0b064 Cr-Commit-Position: refs/heads/master@{#40581}

Patch Set 1 #

Patch Set 2 : Comment #

Unified diffs Side-by-side diffs Stats (+59 lines, -59 lines)
M src/ast/ast-value-factory.h View 9 chunks +35 lines, -28 lines 0 comments
M src/ast/ast-value-factory.cc View 7 chunks +24 lines, -31 lines 0 comments

Messages

Total messages: 14 (9 generated)
Toon Verwaest
ptal, this approach is actually a little more general than what I had done before
4 years, 1 month ago (2016-10-26 07:43:07 UTC) #8
adamk
lgtm
4 years, 1 month ago (2016-10-26 08:45:05 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2449223002/20001
4 years, 1 month ago (2016-10-26 09:36:18 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-10-26 09:37:59 UTC) #12
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:13:28 UTC) #14
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/a16701598c029320bc0b3f60727a5fc148e0b064
Cr-Commit-Position: refs/heads/master@{#40581}

Powered by Google App Engine