Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(377)

Issue 2449213004: Remove SkMovie and giflib (Closed)

Created:
4 years, 1 month ago by scroggo_chromium
Modified:
4 years, 1 month ago
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Remove SkMovie and giflib SkMovie is not used in any of our tests or by Chromium. It is also not supported by GN. It is being moved into Android, its only client, so we can delete it here. giflib is only used by SkMovie, so stop pulling/building it. TBR=reed@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=3945 Change-Id: I28a8155fd59e139bb21ec2295cc22fdced034284 Committed: https://skia.googlesource.com/skia/+/6fe16d3f58937957351fb347a7b1dffa0e0768bc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -778 lines) Patch
M DEPS View 1 chunk +0 lines, -1 line 0 comments Download
D gyp/giflib.gyp View 1 chunk +0 lines, -73 lines 0 comments Download
M gyp/images.gyp View 4 chunks +0 lines, -14 lines 0 comments Download
D include/images/SkMovie.h View 1 chunk +0 lines, -80 lines 0 comments Download
D src/images/SkGIFMovie.cpp View 1 chunk +0 lines, -451 lines 0 comments Download
D src/images/SkMovie.cpp View 1 chunk +0 lines, -94 lines 0 comments Download
D src/images/SkMovie_FactoryDefault.cpp View 1 chunk +0 lines, -26 lines 0 comments Download
M src/ports/SkImageEncoder_none.cpp View 1 chunk +0 lines, -9 lines 0 comments Download
D third_party/giflib/BUILD.gn View 1 chunk +0 lines, -23 lines 0 comments Download
D third_party/giflib/unistd.h View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
scroggo_chromium
4 years, 1 month ago (2016-10-27 17:56:25 UTC) #3
mtklein_C
lgtm
4 years, 1 month ago (2016-10-27 18:27:06 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2449213004/1
4 years, 1 month ago (2016-10-27 18:34:30 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: skia_presubmit-Trybot on master.client.skia.fyi (JOB_FAILED, http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/builds/15424)
4 years, 1 month ago (2016-10-27 18:42:03 UTC) #9
scroggo_chromium
Adding reed@ to TBR; I know he supports this
4 years, 1 month ago (2016-10-27 19:23:12 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2449213004/1
4 years, 1 month ago (2016-10-27 19:23:28 UTC) #14
commit-bot: I haz the power
4 years, 1 month ago (2016-10-27 19:24:48 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/6fe16d3f58937957351fb347a7b1dffa0e0768bc

Powered by Google App Engine
This is Rietveld 408576698