Issue 2449213003: GN: Try to fix Linux build on bots - Code Review

Chromium Code Reviews

chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out

(718)

My Issues | Starred Open | Closed | All

Issue 2449213003: GN: Try to fix Linux build on bots (Closed)

Created:
4 years, 1 month ago by zra

Modified:
4 years, 1 month ago

Reviewers:
Bill Hesse, rmacnak

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

GN: Try to fix Linux build on bots Committed: https://github.com/dart-lang/sdk/commit/c1b08a0b970ff89d11b48cf6b2bc8f39767a3d34

Patch Set 1 #

Created: 4 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -2 lines)			Patch
	M	runtime/BUILD.gn	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	utils/dartdevc/BUILD.gn	View		1 chunk	+5 lines, -1 line	0 comments	Download

Messages

Total messages: 7 (3 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

zra

Committed patchset #1 (id:1) manually as c1b08a0b970ff89d11b48cf6b2bc8f39767a3d34 (presubmit successful).

4 years, 1 month ago (2016-10-26 17:48:19 UTC) #4

zra

This appears to have done the trick. @rmacnak when creating the sdk, we have to ...

4 years, 1 month ago (2016-10-26 17:54:01 UTC) #6

Message was sent while issue was closed.

lgtm

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Powered by Google App Engine

This is Rietveld 408576698