Mus: Introduce DisplayCompositorClient mojo interface

Mus: Introduce DisplayCompositorClient mojo interface

BUG=658988
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Committed: https://crrev.com/fd24c28f0f2c34d919703c58432f5044bef6b155
Cr-Commit-Position: refs/heads/master@{#429210}

[Fady Samuel, 2016-10-26 17:31:59]

Description was changed from

==========
Mus: Introduce DisplayCompositorClient mojo interface

BUG=658988
==========

to

==========
Mus: Introduce DisplayCompositorClient mojo interface

BUG=658988
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[Fady Samuel, 2016-10-26 17:33:26]

fsamuel@chromium.org changed reviewers:
+ enne@chromium.org, sky@chromium.org, tsepez@chromium.org

[Fady Samuel, 2016-10-26 17:33:26]

+sky@ for services/ui
+enne@ for cc signoff
+tsepez@ for mojom

[Tom Sepez, 2016-10-26 17:46:55]

mojom LGTM

[rjkroege, 2016-10-26 17:48:18]

rjkroege@chromium.org changed reviewers:
+ rjkroege@chromium.org

[rjkroege, 2016-10-26 17:48:19]

https://codereview.chromium.org/2449173003/diff/1/cc/ipc/display_compositor.m...
File cc/ipc/display_compositor.mojom (right):

https://codereview.chromium.org/2449173003/diff/1/cc/ipc/display_compositor.m...
cc/ipc/display_compositor.mojom:12: // time.
drive by ask for more wordy docs.

Can you explain more. Any client? Does it have to listen? When it is called?
etc.? Threading rules? How does this fit into the surface flow etc.? I know
you've written some of this in your design docs already so maybe it could be
added here.

[sky, 2016-10-26 17:54:33]

LGTM

[Fady Samuel, 2016-10-26 18:02:47]

PTAL Rob. I added a few more comments.

[rjkroege, 2016-10-26 18:37:03]

https://codereview.chromium.org/2449173003/diff/20001/cc/ipc/display_composit...
File cc/ipc/display_compositor.mojom (right):

https://codereview.chromium.org/2449173003/diff/20001/cc/ipc/display_composit...
cc/ipc/display_compositor.mojom:16: // time.
When? i.e.: can the DCH rely on this being called immediately on receipt of the
surface? Or can the DC defer such updates under certain circumstances?

[enne (OOO), 2016-10-26 18:55:51]

lgtm

[Fady Samuel, 2016-10-26 18:57:31]

Updated comment. PTAL Rob!

[rjkroege, 2016-10-26 19:00:09]

mojo comments lgtm

[Fady Samuel, 2016-10-26 19:01:38]

The CQ bit was checked by fsamuel@chromium.org

[Fady Samuel, 2016-10-26 19:01:39]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org,
sky@chromium.org, enne@chromium.org
Link to the patchset: https://codereview.chromium.org/2449173003/#ps40001
(title: "Updated")

[commit-bot: I haz the power, 2016-10-26 19:03:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-26 19:19:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-26 19:19:03]

Try jobs failed on following builders:
  chromeos_x86-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)

[Fady Samuel, 2016-10-27 04:35:15]

The CQ bit was checked by fsamuel@chromium.org

[Fady Samuel, 2016-10-27 04:35:16]

The patchset sent to the CQ was uploaded after l-g-t-m from
rjkroege@chromium.org, tsepez@chromium.org, sky@chromium.org, enne@chromium.org
Link to the patchset: https://codereview.chromium.org/2449173003/#ps60001
(title: "Fix includes")

[commit-bot: I haz the power, 2016-10-27 04:35:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-27 05:05:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-27 05:06:00]

Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[Fady Samuel, 2016-10-27 06:06:37]

The CQ bit was checked by fsamuel@chromium.org

[commit-bot: I haz the power, 2016-10-27 06:07:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-27 06:48:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-27 06:48:48]

Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[Fady Samuel, 2016-10-27 10:33:08]

The CQ bit was checked by fsamuel@chromium.org

[Fady Samuel, 2016-10-27 10:33:09]

The patchset sent to the CQ was uploaded after l-g-t-m from
rjkroege@chromium.org, tsepez@chromium.org, sky@chromium.org, enne@chromium.org
Link to the patchset: https://codereview.chromium.org/2449173003/#ps80001
(title: "Add deps")

[commit-bot: I haz the power, 2016-10-27 10:33:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-27 11:41:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-27 11:41:15]

Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[Fady Samuel, 2016-10-27 22:24:59]

fsamuel@chromium.org changed reviewers:
+ rockot@chromium.org

[Fady Samuel, 2016-10-27 22:25:00]

+rockot@ FYI: I took your suggestion to fix the bots complaining.

[Ken Rockot(use gerrit already), 2016-10-27 22:47:08]

On 2016/10/27 at 22:25:00, fsamuel wrote:
> +rockot@ FYI: I took your suggestion to fix the bots complaining.

LGTM. To clarify what the fix was here:

Unfortunately for mojom which are linked into components and have their symbols
exported (via the magic on targets like
third_party/WebKit/public:mojo_bindings), we cannot expose direct interface
method dependencies on mojom types which *aren't* exported by a component.
Wrapping such types in an intermediate struct is sufficient to work around
linker errors that would otherwise result.

[Fady Samuel, 2016-10-27 22:48:51]

The CQ bit was checked by fsamuel@chromium.org

[Fady Samuel, 2016-10-27 22:48:52]

The patchset sent to the CQ was uploaded after l-g-t-m from
rjkroege@chromium.org, tsepez@chromium.org, sky@chromium.org, enne@chromium.org
Link to the patchset: https://codereview.chromium.org/2449173003/#ps100001
(title: "Took rockot's suggestion for fixing build")

[commit-bot: I haz the power, 2016-10-27 22:50:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-27 23:48:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-27 23:48:58]

Try jobs failed on following builders:
  win_clang on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[Fady Samuel, 2016-10-28 14:25:48]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-28 14:26:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-28 15:18:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-28 15:18:54]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[Fady Samuel, 2016-10-28 15:36:43]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-28 15:37:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-28 16:04:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-28 16:04:27]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)

[Fady Samuel, 2016-11-01 17:05:48]

The CQ bit was unchecked by fsamuel@chromium.org

[Fady Samuel, 2016-11-01 17:05:49]

The CQ bit was checked by fsamuel@chromium.org

[Fady Samuel, 2016-11-01 17:05:49]

The patchset sent to the CQ was uploaded after l-g-t-m from
rjkroege@chromium.org, tsepez@chromium.org, enne@chromium.org, sky@chromium.org,
rockot@chromium.org
Link to the patchset: https://codereview.chromium.org/2449173003/#ps140001
(title: "Updated to public_deps")

[Fady Samuel, 2016-11-01 17:05:49]

The CQ bit was checked by fsamuel@chromium.org

[Fady Samuel, 2016-11-01 17:05:50]

The patchset sent to the CQ was uploaded after l-g-t-m from
rjkroege@chromium.org, tsepez@chromium.org, enne@chromium.org, sky@chromium.org,
rockot@chromium.org
Link to the patchset: https://codereview.chromium.org/2449173003/#ps140001
(title: "Updated to public_deps")

[commit-bot: I haz the power, 2016-11-01 17:06:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-01 18:10:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-01 18:10:10]

Try jobs failed on following builders:
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)

[Fady Samuel, 2016-11-02 03:54:35]

The CQ bit was checked by fsamuel@chromium.org

[Fady Samuel, 2016-11-02 03:54:36]

The patchset sent to the CQ was uploaded after l-g-t-m from
rjkroege@chromium.org, tsepez@chromium.org, enne@chromium.org, sky@chromium.org,
rockot@chromium.org
Link to the patchset: https://codereview.chromium.org/2449173003/#ps160001
(title: "Explicitly add ui/gfx/geometry/mojo dependency")

[commit-bot: I haz the power, 2016-11-02 03:54:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-02 04:48:46]

Committed patchset #9 (id:160001)

[commit-bot: I haz the power, 2016-11-02 04:50:35]

Description was changed from

==========
Mus: Introduce DisplayCompositorClient mojo interface

BUG=658988
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
Mus: Introduce DisplayCompositorClient mojo interface

BUG=658988
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Committed: https://crrev.com/fd24c28f0f2c34d919703c58432f5044bef6b155
Cr-Commit-Position: refs/heads/master@{#429210}
==========

[commit-bot: I haz the power, 2016-11-02 04:50:37]

Patchset 9 (id:??) landed as
https://crrev.com/fd24c28f0f2c34d919703c58432f5044bef6b155
Cr-Commit-Position: refs/heads/master@{#429210}