|
|
Chromium Code Reviews|
Created:
4 years, 1 month ago by Jamie Madill Modified:
4 years, 1 month ago Reviewers:
Ken Russell (switch to Gerrit) CC:
chromium-reviews, jam, darin-cc_chromium.org, piman+watch_chromium.org, ajuma, jaydasika Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Descriptiongpu: Add duplicate AMD bot configs.
Many of the AMD configs were referring to themselves as ATI, which is
very out of date. Change this to AMD. Also update bot names as
required, and PCI device ids where needed.
This will require two more steps: one to update the build side
integration, and finally to remove the old configs.
BUG=639353, 649863, 641080
R=kbr@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
NOTRY=true
Committed: https://crrev.com/01b12a365a3f04f97d9dadd3263c7760348b0740
Cr-Commit-Position: refs/heads/master@{#428207}
Patch Set 1 #Patch Set 2 : Keep old configs around. #
Total comments: 2
Patch Set 3 : Fixed PCI for AMD bot #
Messages
Total messages: 33 (18 generated)
Description was changed from ========== gpu: Update AMD bot configs, and add dEQP tests. Many of the AMD configs were referring to themselves as ATI, which is very out of date. Change this to AMD. Also update bot names as required, and PCI device ids where needed. Also added the dEQP-GLES3 tests to the AMD Windows FYI bot, since we need to keep good GLES3 conformance for WebGL 2 support. BUG=639353,649863,641080 R=kbr@chromium.org ========== to ========== gpu: Update AMD bot configs, and add dEQP tests. Many of the AMD configs were referring to themselves as ATI, which is very out of date. Change this to AMD. Also update bot names as required, and PCI device ids where needed. Also added the dEQP-GLES3 tests to the AMD Windows FYI bot, since we need to keep good GLES3 conformance for WebGL 2 support. BUG=639353,649863,641080 R=kbr@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel ==========
The CQ bit was checked by jmadill@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
PTAL Ken, can you predict if this is going to detonate the FYI waterfal?
The machine renaming will not work. To do it, a multi-step process has to be done: 1) Duplicate the machine names (have both old and new at the same time) in generate_buildbot_json.py and mb_config.pyl 2) Rename the machines in the tools/build workspace 3) Restart the affected waterfalls (in this case, chromium.gpu.fyi) 4) Delete the old machine names from the chromium/src workspace Some of this is documented in https://www.chromium.org/developers/testing/gpu-testing/gpu-bot-details#TOC-H... .
Description was changed from ========== gpu: Update AMD bot configs, and add dEQP tests. Many of the AMD configs were referring to themselves as ATI, which is very out of date. Change this to AMD. Also update bot names as required, and PCI device ids where needed. Also added the dEQP-GLES3 tests to the AMD Windows FYI bot, since we need to keep good GLES3 conformance for WebGL 2 support. BUG=639353,649863,641080 R=kbr@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel ========== to ========== gpu: Add duplicate AMD bot configs. Many of the AMD configs were referring to themselves as ATI, which is very out of date. Change this to AMD. Also update bot names as required, and PCI device ids where needed. This will require two more steps: one to update the build side integration, and finally to remove the old configs. BUG=639353,649863,641080 R=kbr@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel ==========
PTAL at Patch Set 2 Ken. I kept the old configs, and didn't add the GLES3 tests to keep things simpler. Will this explode?
LGTM with one change. https://codereview.chromium.org/2449163002/diff/20001/content/test/gpu/genera... File content/test/gpu/generate_buildbot_json.py (right): https://codereview.chromium.org/2449163002/diff/20001/content/test/gpu/genera... content/test/gpu/generate_buildbot_json.py:298: 'gpu': '1002:6613', The device ID for this card is 0x6779 per the bots' logs. (It's at the top of the stdio for any Telemetry based test.) This isn't critical since this bot doesn't use Swarming but it's good to keep the bookkeeping straight.
https://codereview.chromium.org/2449163002/diff/20001/content/test/gpu/genera... File content/test/gpu/generate_buildbot_json.py (right): https://codereview.chromium.org/2449163002/diff/20001/content/test/gpu/genera... content/test/gpu/generate_buildbot_json.py:298: 'gpu': '1002:6613', On 2016/10/26 21:58:10, Ken Russell wrote: > The device ID for this card is 0x6779 per the bots' logs. (It's at the top of > the stdio for any Telemetry based test.) This isn't critical since this bot > doesn't use Swarming but it's good to keep the bookkeeping straight. Good catch, fixed. This is important because it governs if we run the dEQP tests or not.
The CQ bit was checked by jmadill@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from kbr@chromium.org Link to the patchset: https://codereview.chromium.org/2449163002/#ps40001 (title: "Fixed PCI for AMD bot")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_optional_gpu_tests_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_opti...)
The CQ bit was checked by jmadill@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_optional_gpu_tests_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_opti...)
The CQ bit was checked by jmadill@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_optional_gpu_tests_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_opti...)
Description was changed from ========== gpu: Add duplicate AMD bot configs. Many of the AMD configs were referring to themselves as ATI, which is very out of date. Change this to AMD. Also update bot names as required, and PCI device ids where needed. This will require two more steps: one to update the build side integration, and finally to remove the old configs. BUG=639353,649863,641080 R=kbr@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel ========== to ========== gpu: Add duplicate AMD bot configs. Many of the AMD configs were referring to themselves as ATI, which is very out of date. Change this to AMD. Also update bot names as required, and PCI device ids where needed. This will require two more steps: one to update the build side integration, and finally to remove the old configs. BUG=639353,649863,641080 R=kbr@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel ==========
On 2016/10/27 23:01:32, commit-bot: I haz the power wrote: > Try jobs failed on following builders: > android_optional_gpu_tests_rel on master.tryserver.chromium.android > (JOB_FAILED, > https://build.chromium.org/p/tryserver.chromium.android/builders/android_opti...) That's being fixed in: https://codereview.chromium.org/2459613003/ Bypassing the CQ for this unrelated failure.
Description was changed from ========== gpu: Add duplicate AMD bot configs. Many of the AMD configs were referring to themselves as ATI, which is very out of date. Change this to AMD. Also update bot names as required, and PCI device ids where needed. This will require two more steps: one to update the build side integration, and finally to remove the old configs. BUG=639353,649863,641080 R=kbr@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel ========== to ========== gpu: Add duplicate AMD bot configs. Many of the AMD configs were referring to themselves as ATI, which is very out of date. Change this to AMD. Also update bot names as required, and PCI device ids where needed. This will require two more steps: one to update the build side integration, and finally to remove the old configs. BUG=639353,649863,641080 R=kbr@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel NOTRY=true ==========
The CQ bit was checked by kbr@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== gpu: Add duplicate AMD bot configs. Many of the AMD configs were referring to themselves as ATI, which is very out of date. Change this to AMD. Also update bot names as required, and PCI device ids where needed. This will require two more steps: one to update the build side integration, and finally to remove the old configs. BUG=639353,649863,641080 R=kbr@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel NOTRY=true ========== to ========== gpu: Add duplicate AMD bot configs. Many of the AMD configs were referring to themselves as ATI, which is very out of date. Change this to AMD. Also update bot names as required, and PCI device ids where needed. This will require two more steps: one to update the build side integration, and finally to remove the old configs. BUG=639353,649863,641080 R=kbr@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel NOTRY=true ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== gpu: Add duplicate AMD bot configs. Many of the AMD configs were referring to themselves as ATI, which is very out of date. Change this to AMD. Also update bot names as required, and PCI device ids where needed. This will require two more steps: one to update the build side integration, and finally to remove the old configs. BUG=639353,649863,641080 R=kbr@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel NOTRY=true ========== to ========== gpu: Add duplicate AMD bot configs. Many of the AMD configs were referring to themselves as ATI, which is very out of date. Change this to AMD. Also update bot names as required, and PCI device ids where needed. This will require two more steps: one to update the build side integration, and finally to remove the old configs. BUG=639353,649863,641080 R=kbr@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel NOTRY=true Committed: https://crrev.com/01b12a365a3f04f97d9dadd3263c7760348b0740 Cr-Commit-Position: refs/heads/master@{#428207} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/01b12a365a3f04f97d9dadd3263c7760348b0740 Cr-Commit-Position: refs/heads/master@{#428207} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
