Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(443)

Issue 2449163002: gpu: Update AMD bot configs, and add dEQP tests. (Closed)

Created:
4 years, 1 month ago by Jamie Madill
Modified:
4 years, 1 month ago
CC:
chromium-reviews, jam, darin-cc_chromium.org, piman+watch_chromium.org, ajuma, jaydasika
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

gpu: Add duplicate AMD bot configs. Many of the AMD configs were referring to themselves as ATI, which is very out of date. Change this to AMD. Also update bot names as required, and PCI device ids where needed. This will require two more steps: one to update the build side integration, and finally to remove the old configs. BUG=639353, 649863, 641080 R=kbr@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel NOTRY=true Committed: https://crrev.com/01b12a365a3f04f97d9dadd3263c7760348b0740 Cr-Commit-Position: refs/heads/master@{#428207}

Patch Set 1 #

Patch Set 2 : Keep old configs around. #

Total comments: 2

Patch Set 3 : Fixed PCI for AMD bot #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3682 lines, -1017 lines) Patch
M content/test/gpu/generate_buildbot_json.py View 1 2 7 chunks +85 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.gpu.fyi.json View 1 2 397 chunks +3597 lines, -1017 lines 0 comments Download

Messages

Total messages: 33 (18 generated)
Jamie Madill
PTAL Ken, can you predict if this is going to detonate the FYI waterfal?
4 years, 1 month ago (2016-10-25 20:51:41 UTC) #6
Ken Russell (switch to Gerrit)
The machine renaming will not work. To do it, a multi-step process has to be ...
4 years, 1 month ago (2016-10-25 21:42:04 UTC) #7
Jamie Madill
PTAL at Patch Set 2 Ken. I kept the old configs, and didn't add the ...
4 years, 1 month ago (2016-10-26 19:45:38 UTC) #9
Ken Russell (switch to Gerrit)
LGTM with one change. https://codereview.chromium.org/2449163002/diff/20001/content/test/gpu/generate_buildbot_json.py File content/test/gpu/generate_buildbot_json.py (right): https://codereview.chromium.org/2449163002/diff/20001/content/test/gpu/generate_buildbot_json.py#newcode298 content/test/gpu/generate_buildbot_json.py:298: 'gpu': '1002:6613', The device ID ...
4 years, 1 month ago (2016-10-26 21:58:10 UTC) #10
Jamie Madill
https://codereview.chromium.org/2449163002/diff/20001/content/test/gpu/generate_buildbot_json.py File content/test/gpu/generate_buildbot_json.py (right): https://codereview.chromium.org/2449163002/diff/20001/content/test/gpu/generate_buildbot_json.py#newcode298 content/test/gpu/generate_buildbot_json.py:298: 'gpu': '1002:6613', On 2016/10/26 21:58:10, Ken Russell wrote: > ...
4 years, 1 month ago (2016-10-27 16:48:36 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2449163002/40001
4 years, 1 month ago (2016-10-27 16:49:03 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: android_optional_gpu_tests_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_optional_gpu_tests_rel/builds/785)
4 years, 1 month ago (2016-10-27 18:23:20 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2449163002/40001
4 years, 1 month ago (2016-10-27 18:35:03 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: android_optional_gpu_tests_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_optional_gpu_tests_rel/builds/792)
4 years, 1 month ago (2016-10-27 20:57:42 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2449163002/40001
4 years, 1 month ago (2016-10-27 21:00:15 UTC) #22
commit-bot: I haz the power
Try jobs failed on following builders: android_optional_gpu_tests_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_optional_gpu_tests_rel/builds/796)
4 years, 1 month ago (2016-10-27 23:01:32 UTC) #24
Ken Russell (switch to Gerrit)
On 2016/10/27 23:01:32, commit-bot: I haz the power wrote: > Try jobs failed on following ...
4 years, 1 month ago (2016-10-27 23:08:47 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2449163002/40001
4 years, 1 month ago (2016-10-27 23:10:09 UTC) #29
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 1 month ago (2016-10-27 23:27:37 UTC) #31
commit-bot: I haz the power
4 years, 1 month ago (2016-10-27 23:29:24 UTC) #33
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/01b12a365a3f04f97d9dadd3263c7760348b0740
Cr-Commit-Position: refs/heads/master@{#428207}

Powered by Google App Engine
This is Rietveld 408576698