Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(911)

Unified Diff: chrome/browser/ui/views/tabs/tab_drag_controller.cc

Issue 2449103004: Refactor WindowFinder definition (Closed)
Patch Set: setting mus_window to null, for safety Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/views/tabs/window_finder.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/tabs/tab_drag_controller.cc
diff --git a/chrome/browser/ui/views/tabs/tab_drag_controller.cc b/chrome/browser/ui/views/tabs/tab_drag_controller.cc
index 1e6e2d4fe0f46fa0f9f249a9948dddc34bc9215b..58c0ec48724b2b663ae21131429d711434ec87a8 100644
--- a/chrome/browser/ui/views/tabs/tab_drag_controller.cc
+++ b/chrome/browser/ui/views/tabs/tab_drag_controller.cc
@@ -49,9 +49,6 @@
#endif
#if defined(USE_AURA)
-#include "chrome/browser/ui/views/tabs/window_finder_mus.h" // nogncheck
-#include "content/public/common/service_manager_connection.h" // nogncheck
-#include "services/service_manager/runner/common/client_util.h" // nogncheck
#include "ui/aura/env.h" // nogncheck
#include "ui/aura/window.h" // nogncheck
#include "ui/wm/core/window_modality_controller.h" // nogncheck
@@ -225,17 +222,9 @@ TabDragController::TabDragController()
is_mutating_(false),
attach_x_(-1),
attach_index_(-1),
+ window_finder_(base::MakeUnique<WindowFinder>()),
weak_factory_(this) {
instance_ = this;
-
-#if defined(USE_AURA)
- content::ServiceManagerConnection* service_manager_connection =
- content::ServiceManagerConnection::GetForProcess();
- if (service_manager_connection && service_manager::ServiceManagerIsRemote())
- window_finder_.reset(new WindowFinderMus);
- else
-#endif
- window_finder_.reset(new WindowFinder);
}
TabDragController::~TabDragController() {
« no previous file with comments | « no previous file | chrome/browser/ui/views/tabs/window_finder.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698