Refactor WindowFinder definition

chrome/browser/ui/views/tabs/window_finder.h

Index: chrome/browser/ui/views/tabs/window_finder.h
diff --git a/chrome/browser/ui/views/tabs/window_finder.h b/chrome/browser/ui/views/tabs/window_finder.h
index 4ce91d50ed01aad9fa9b789755e9e2c4bbda835e..359147f0a35ed17833233f3dc527874fc309d592 100644
--- a/chrome/browser/ui/views/tabs/window_finder.h
+++ b/chrome/browser/ui/views/tabs/window_finder.h
@@ -21,8 +21,8 @@ class Point;
 // to.
 class WindowFinder {

[sky, 2016/10/28 16:54:48]

There is no point in making this a class. A single function suffices. Here is
what I would like to see: no class here. Only the single function:
GetLocalProcessWindowAtPoint().

In window_finder_mus.h there is a function GetLocalProcessWindowAtPointMus()
(again no class, just a function). Make this function have a boolean return
value and an additional param gfx::NativeWindow* value. For the platforms that
support mus, e.g. win, x11... GetLocalProcessWindowAtPoint looks like:

if (GetLocalProcessWindowAtPointMus(...))
  return window;
// existing logic.

Make sense?

[tonikitoo, 2016/10/28 20:05:48]

Yes, it makes sense. patchset 10 implements the idea.

The biggest problem I see now is the unittest
chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc , where
WindowFinder is derived and GetLocalProcessWindowAtPoint overriden.

  public:
-  WindowFinder();
-  virtual ~WindowFinder();
+  WindowFinder() {}
+  virtual ~WindowFinder() {}
 
   // Finds the topmost visible chrome window at |screen_point|. This should
   // return nullptr if |screen_point| is in another program's window which
@@ -33,6 +33,10 @@ class WindowFinder {
       const std::set<gfx::NativeWindow>& ignore);
 
  private:
+  gfx::NativeWindow GetLocalProcessWindowAtPointImpl(
+      const gfx::Point& screen_point,
+      const std::set<gfx::NativeWindow>& ignore);
+
   DISALLOW_COPY_AND_ASSIGN(WindowFinder);
 };