chrome/browser/ui/views/tabs/window_finder_chromeos.cc - Issue 2449103004: Refactor WindowFinder definition

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/ui/views/tabs/window_finder_chromeos.cc

Issue 2449103004: Refactor WindowFinder definition (Closed)

Patch Set: addressed more of sky's feedback Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/browser/ui/views/tabs/window_finder.h ('k') | chrome/browser/ui/views/tabs/window_finder_mus.h » ('j') | chrome/browser/ui/views/tabs/window_finder_mus.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "chrome/browser/ui/views/tabs/window_finder.h"	5 #include "chrome/browser/ui/views/tabs/window_finder.h"

	6 #include "chrome/browser/ui/views/tabs/window_finder_mus.h"

6	7

7 #include "ui/aura/window.h"	8 #include "ui/aura/window.h"

8	9

9 gfx::NativeWindow GetLocalProcessWindowAtPointAsh(	10 gfx::NativeWindow GetLocalProcessWindowAtPointAsh(

10 const gfx::Point& screen_point,	11 const gfx::Point& screen_point,

11 const std::set<gfx::NativeWindow>& ignore);	12 const std::set<gfx::NativeWindow>& ignore);

12	13

13 gfx::NativeWindow WindowFinder::GetLocalProcessWindowAtPoint(	14 gfx::NativeWindow WindowFinder::GetLocalProcessWindowAtPoint(

14 const gfx::Point& screen_point,	15 const gfx::Point& screen_point,

15 const std::set<gfx::NativeWindow>& ignore) {	16 const std::set<gfx::NativeWindow>& ignore) {

	17 gfx::NativeWindow out;
	sky 2016/10/31 20:33:20 out is descriptive, maybe mus_result? (same commen out is descriptive, maybe mus_result? (same comment for other files) tonikitoo 2016/10/31 21:09:13 Done. Show quoted text On 2016/10/31 20:33:20, sky wrote: > out is descriptive, maybe mus_result? (same comment for other files) Done.
	18 if (GetLocalProcessWindowAtPointMus(screen_point, ignore, &out))

	19 return out;

	20

16 return GetLocalProcessWindowAtPointAsh(screen_point, ignore);	21 return GetLocalProcessWindowAtPointAsh(screen_point, ignore);

17 }	22 }

OLD	NEW