Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Issue 2449103002: binding: Makes event listener attributes use the relevant realm. (Closed)

Created:
4 years, 1 month ago by Yuki
Modified:
4 years, 1 month ago
Reviewers:
haraken, peria
CC:
chromium-reviews, blink-reviews, blink-reviews-bindings_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

binding: Makes event listener attributes use the relevant realm. Makes onxxx attributes use the relevant realm for the context object. In my investigation, the realm used here shouldn't be observable by user script, but anyway we'd like to replace ScriptState::current() with either of forFunctionObject or forReceiverObject. BUG=618672 Committed: https://crrev.com/6ffd879eb8bcc2d15521ec42293811f3d78b5527 Cr-Commit-Position: refs/heads/master@{#427629}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -5 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/ScriptState.h View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/bindings/scripts/v8_attributes.py View 1 chunk +7 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterface.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceNode.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestObject.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (8 generated)
Yuki
Could you review this CL?
4 years, 1 month ago (2016-10-26 07:30:44 UTC) #6
haraken
LGTM
4 years, 1 month ago (2016-10-26 07:34:18 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2449103002/1
4 years, 1 month ago (2016-10-26 07:35:47 UTC) #9
peria
lgtm
4 years, 1 month ago (2016-10-26 07:37:05 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-26 07:40:27 UTC) #12
commit-bot: I haz the power
4 years, 1 month ago (2016-10-26 07:42:30 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6ffd879eb8bcc2d15521ec42293811f3d78b5527
Cr-Commit-Position: refs/heads/master@{#427629}

Powered by Google App Engine
This is Rietveld 408576698