tools/dom/scripts/systemnative.py - Issue 24491003: Revert "Revert "Start of dartium custom element lifecycle event support.""

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/dom/scripts/systemnative.py

Issue 24491003: Revert "Revert "Start of dartium custom element lifecycle event support."" (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/dom/scripts/htmlrenamer.py ('k') | tools/dom/src/native_DOMImplementation.dart » ('j') | tools/dom/templates/html/impl/impl_Document.darttemplate » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/dom/scripts/systemnative.py

diff --git a/tools/dom/scripts/systemnative.py b/tools/dom/scripts/systemnative.py

index 038825c60331ff7c517d43e90bc72947f67d7cb0..8dbe0e224ec7e1724b57227cbb913930aee21c5a 100644

--- a/tools/dom/scripts/systemnative.py

+++ b/tools/dom/scripts/systemnative.py

@@ -789,13 +789,13 @@ class DartiumBackend(HtmlDartGenerator):

if 'Reflect' in ext_attrs:

cpp_arguments = [self._GenerateWebCoreReflectionAttributeName(node)]

- if return_type_is_nullable:

- cpp_arguments = ['isNull']

if ext_attrs.get('CustomElementCallbacks') == 'Enable':

self._cpp_impl_includes.add('"core/dom/CustomElementCallbackDispatcher.h"')

needs_custom_element_callbacks = True

+ if return_type_is_nullable:

+ cpp_arguments = ['isNull']

v8EnabledPerContext = ext_attrs.get('synthesizedV8EnabledPerContext', ext_attrs.get('V8EnabledPerContext'))

v8EnabledAtRuntime = ext_attrs.get('synthesizedV8EnabledAtRuntime', ext_attrs.get('V8EnabledAtRuntime'))

assert(not (v8EnabledPerContext and v8EnabledAtRuntime))