[ObjC ARC] Converts ios/chrome/app to ARC.

[ObjC ARC] Converts ios/chrome/app to ARC.

Notable changes:none.

BUG=659150
TEST=None.

Committed: https://crrev.com/7a1f218b33faf5d0dd637f6a6854566e6cd80a3d
Cr-Commit-Position: refs/heads/master@{#427722}

[stkhapugin, 2016-10-25 15:09:49]

The CQ bit was checked by stkhapugin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-25 15:10:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[stkhapugin, 2016-10-25 16:11:26]

stkhapugin@chromium.org changed reviewers:
+ eugenebut@chromium.org

[stkhapugin, 2016-10-25 16:11:26]

ptal

[commit-bot: I haz the power, 2016-10-25 16:11:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-25 16:11:52]

Dry run: This issue passed the CQ dry run.

[Eugene But (OOO till 7-30), 2016-10-25 20:11:28]

lgtm

[stkhapugin, 2016-10-26 15:50:04]

The CQ bit was checked by stkhapugin@chromium.org

[commit-bot: I haz the power, 2016-10-26 15:50:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-26 17:03:58]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-10-26 17:12:54]

Description was changed from

==========
[ObjC ARC] Converts ios/chrome/app to ARC.

Notable changes:none.

BUG=659150
TEST=None.
==========

to

==========
[ObjC ARC] Converts ios/chrome/app to ARC.

Notable changes:none.

BUG=659150
TEST=None.

Committed: https://crrev.com/7a1f218b33faf5d0dd637f6a6854566e6cd80a3d
Cr-Commit-Position: refs/heads/master@{#427722}
==========

[commit-bot: I haz the power, 2016-10-26 17:12:54]

Patchset 1 (id:??) landed as
https://crrev.com/7a1f218b33faf5d0dd637f6a6854566e6cd80a3d
Cr-Commit-Position: refs/heads/master@{#427722}

[Lei Zhang, 2016-10-26 17:20:26]

thestig@chromium.org changed reviewers:
+ thestig@chromium.org

[Lei Zhang, 2016-10-26 17:20:26]

Notable changes: tree is red. @_@

Revert?

[mohsen, 2016-10-26 17:23:10]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2453033002/ by mohsen@chromium.org.

The reason for reverting is: Compile failure on ios-device builder:
https://uberchromegw.corp.google.com/i/chromium.mac/builders/ios-device/build....

[Lei Zhang, 2016-10-26 17:28:20]

Here's the actual error, for the record:

FAILED: obj/ios/chrome/app/app/safe_mode_crashing_modules_config.o 
/b/build/slave/cache/cipd/goma/gomacc
../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF
obj/ios/chrome/app/app/safe_mode_crashing_modules_config.o.d
-DV8_DEPRECATION_WARNINGS -DNO_TCMALLOC -DDISABLE_NACL -DCHROMIUM_BUILD
-DFIELDTRIAL_TESTING_ENABLED -DCR_CLANG_REVISION=284979-1
-DCR_XCODE_VERSION=0800 -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D_DEBUG
-DDYNAMIC_ANNOTATIONS_ENABLED=1 -DWTF_USE_DYNAMIC_ANNOTATIONS=1 -I../.. -Igen
-fno-strict-aliasing --param=ssp-buffer-size=4 -fstack-protector
-fcolor-diagnostics -arch armv7 -Wall -Werror -Wextra
-Wno-missing-field-initializers -Wno-unused-parameter -Wno-c++11-narrowing
-Wno-covered-switch-default -Wno-deprecated-register
-Wno-unneeded-internal-declaration -Wno-inconsistent-missing-override
-Wno-shift-negative-value -Wno-undefined-var-template
-Wno-nonportable-include-path -Wno-address-of-packed-member -O0 -gdwarf-2
-isysroot
/Applications/Xcode8.0.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS10.0.sdk
-stdlib=libc++ -miphoneos-version-min=9.0 -fvisibility=hidden -Xclang -load
-Xclang
../../third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.dylib
-Xclang -add-plugin -Xclang find-bad-constructs -Wheader-hygiene
-Wstring-conversion -fno-threadsafe-statics -fvisibility-inlines-hidden
-Wno-undefined-bool-conversion -Wno-tautological-undefined-compare -std=c++11
-fobjc-call-cxx-cdtors -Wobjc-missing-property-synthesis -fno-rtti
-fno-exceptions -c ../../ios/chrome/app/safe_mode_crashing_modules_config.mm -o
obj/ios/chrome/app/app/safe_mode_crashing_modules_config.o
../../ios/chrome/app/safe_mode_crashing_modules_config.mm:12:2: error: "This
file requires ARC support."
#error "This file requires ARC support."
 ^
1 error generated.

FAILED: obj/ios/chrome/app/app/deferred_initialization_runner.o 
...
../../ios/chrome/app/deferred_initialization_runner.mm:14:2: error: "This file
requires ARC support."
#error "This file requires ARC support."
 ^
../../ios/chrome/app/deferred_initialization_runner.mm:143:3: error: cannot
create __weak reference in file using manual reference counting
  __weak DeferredInitializationRunner* weakSelf = self;
  ^
2 errors generated.

FAILED:
obj/ios/chrome/app/application_delegate/application_delegate/memory_warning_helper.o

...
../../ios/chrome/app/application_delegate/memory_warning_helper.mm:13:2: error:
"This file requires ARC support."
#error "This file requires ARC support."
 ^
1 error generated.

[hongchan, 2016-10-26 17:31:27]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2452133002/ by hongchan@chromium.org.

The reason for reverting is: This CL closed the tree. The following is a partial
log from the dump.

---
[1265/3927] OBJCXX
obj/ios/chrome/browser/translate/translate/never_translate_infobar_controller.o
[1266/3927] OBJCXX obj/ios/chrome/app/app/safe_mode_crashing_modules_config.o
FAILED: obj/ios/chrome/app/app/safe_mode_crashing_modules_config.o 
/b/build/slave/cache/cipd/goma/gomacc
../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF
obj/ios/chrome/app/app/safe_mode_crashing_modules_config.o.d
-DV8_DEPRECATION_WARNINGS -DNO_TCMALLOC -DDISABLE_NACL -DCHROMIUM_BUILD
-DFIELDTRIAL_TESTING_ENABLED -DCR_CLANG_REVISION=284979-1
-DCR_XCODE_VERSION=0800 -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D_DEBUG
-DDYNAMIC_ANNOTATIONS_ENABLED=1 -DWTF_USE_DYNAMIC_ANNOTATIONS=1 -I../.. -Igen
-fno-strict-aliasing --param=ssp-buffer-size=4 -fstack-protector
-fcolor-diagnostics -arch armv7 -Wall -Werror -Wextra
-Wno-missing-field-initializers -Wno-unused-parameter -Wno-c++11-narrowing
-Wno-covered-switch-default -Wno-deprecated-register
-Wno-unneeded-internal-declaration -Wno-inconsistent-missing-override
-Wno-shift-negative-value -Wno-undefined-var-template
-Wno-nonportable-include-path -Wno-address-of-packed-member -O0 -gdwarf-2
-isysroot
/Applications/Xcode8.0.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS10.0.sdk
-stdlib=libc++ -miphoneos-version-min=9.0 -fvisibility=hidden -Xclang -load
-Xclang
../../third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.dylib
-Xclang -add-plugin -Xclang find-bad-constructs -Wheader-hygiene
-Wstring-conversion -fno-threadsafe-statics -fvisibility-inlines-hidden
-Wno-undefined-bool-conversion -Wno-tautological-undefined-compare -std=c++11
-fobjc-call-cxx-cdtors -Wobjc-missing-property-synthesis -fno-rtti
-fno-exceptions -c ../../ios/chrome/app/safe_mode_crashing_modules_config.mm -o
obj/ios/chrome/app/app/safe_mode_crashing_modules_config.o
../../ios/chrome/app/safe_mode_crashing_modules_config.mm:12:2: error: "This
file requires ARC support."
#error "This file requires ARC support."
 ^
1 error generated.
[1267/3927] CXX obj/components/browser_sync/browser_sync/profile_sync_service.o
ninja: build stopped: subcommand failed..

[sdefresne, 2016-10-26 17:37:24]

On 2016/10/26 17:31:27, hongchan wrote:
> A revert of this CL (patchset #1 id:1) has been created in
> https://codereview.chromium.org/2452133002/ by mailto:hongchan@chromium.org.
> 
> The reason for reverting is: This CL closed the tree. The following is a
partial
> log from the dump.
> 
> ---
> [1265/3927] OBJCXX
>
obj/ios/chrome/browser/translate/translate/never_translate_infobar_controller.o
> [1266/3927] OBJCXX obj/ios/chrome/app/app/safe_mode_crashing_modules_config.o
> FAILED: obj/ios/chrome/app/app/safe_mode_crashing_modules_config.o 
> /b/build/slave/cache/cipd/goma/gomacc
> ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF
> obj/ios/chrome/app/app/safe_mode_crashing_modules_config.o.d
> -DV8_DEPRECATION_WARNINGS -DNO_TCMALLOC -DDISABLE_NACL -DCHROMIUM_BUILD
> -DFIELDTRIAL_TESTING_ENABLED -DCR_CLANG_REVISION=284979-1
> -DCR_XCODE_VERSION=0800 -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS
-D_DEBUG
> -DDYNAMIC_ANNOTATIONS_ENABLED=1 -DWTF_USE_DYNAMIC_ANNOTATIONS=1 -I../.. -Igen
> -fno-strict-aliasing --param=ssp-buffer-size=4 -fstack-protector
> -fcolor-diagnostics -arch armv7 -Wall -Werror -Wextra
> -Wno-missing-field-initializers -Wno-unused-parameter -Wno-c++11-narrowing
> -Wno-covered-switch-default -Wno-deprecated-register
> -Wno-unneeded-internal-declaration -Wno-inconsistent-missing-override
> -Wno-shift-negative-value -Wno-undefined-var-template
> -Wno-nonportable-include-path -Wno-address-of-packed-member -O0 -gdwarf-2
> -isysroot
>
/Applications/Xcode8.0.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS10.0.sdk
> -stdlib=libc++ -miphoneos-version-min=9.0 -fvisibility=hidden -Xclang -load
> -Xclang
> ../../third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.dylib
> -Xclang -add-plugin -Xclang find-bad-constructs -Wheader-hygiene
> -Wstring-conversion -fno-threadsafe-statics -fvisibility-inlines-hidden
> -Wno-undefined-bool-conversion -Wno-tautological-undefined-compare -std=c++11
> -fobjc-call-cxx-cdtors -Wobjc-missing-property-synthesis -fno-rtti
> -fno-exceptions -c ../../ios/chrome/app/safe_mode_crashing_modules_config.mm
-o
> obj/ios/chrome/app/app/safe_mode_crashing_modules_config.o
> ../../ios/chrome/app/safe_mode_crashing_modules_config.mm:12:2: error: "This
> file requires ARC support."
> #error "This file requires ARC support."
>  ^
> 1 error generated.
> [1267/3927] CXX
obj/components/browser_sync/browser_sync/profile_sync_service.o
> ninja: build stopped: subcommand failed..

Sorry about that, we do not have enough capacity to run simulator and device
builder on the CQ. Thank you for reverting.