Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(867)

Issue 2449053003: [promises] move most of FulfillPromise to c++ (Closed)

Created:
4 years, 1 month ago by gsathya
Modified:
4 years, 1 month ago
Reviewers:
adamk
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[promises] move most of FulfillPromise to c++ This causes a 3.1% regression because we unconditionally call out to a runtime function. This patch refactors out most of EnqueuePromiseReactionJob runtime function into a separate function. BUG=v8:5343 Committed: https://crrev.com/d7a8caa92a40aa90c95047f4210c97bbe909f115 Cr-Commit-Position: refs/heads/master@{#40570}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -13 lines) Patch
M src/js/promise.js View 1 chunk +1 line, -5 lines 0 comments Download
M src/runtime/runtime.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/runtime/runtime-internal.cc View 2 chunks +33 lines, -8 lines 0 comments Download

Messages

Total messages: 17 (12 generated)
gsathya
4 years, 1 month ago (2016-10-25 15:13:39 UTC) #7
adamk
lgtm
4 years, 1 month ago (2016-10-25 16:10:28 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2449053003/1
4 years, 1 month ago (2016-10-25 16:10:45 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-25 16:12:26 UTC) #15
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:12:57 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d7a8caa92a40aa90c95047f4210c97bbe909f115
Cr-Commit-Position: refs/heads/master@{#40570}

Powered by Google App Engine
This is Rietveld 408576698