Description was changed from ========== Reformat attributes BUG= ========== to ========== Reformat methods.cpp.tmpl I'm planning to change the format of templates as follows: - Interfaces (https://codereview.chromium.org/2454133002/) - Methods (https://codereview.chromium.org/2460563002/) - Attributes (https://codereview.chromium.org/2449043007/) - Others Because reformatting them at once will be huge, especially for V8TestObject.cpp, and it can costs network if reverted. https://codereview.chromium.org/2446213002/ so I'd like to split it into few changes. ==========
Description was changed from ========== Reformat methods.cpp.tmpl I'm planning to change the format of templates as follows: - Interfaces (https://codereview.chromium.org/2454133002/) - Methods (https://codereview.chromium.org/2460563002/) - Attributes (https://codereview.chromium.org/2449043007/) - Others Because reformatting them at once will be huge, especially for V8TestObject.cpp, and it can costs network if reverted. https://codereview.chromium.org/2446213002/ so I'd like to split it into few changes. ========== to ========== Reformat methods.cpp.tmpl I'm planning to change the format of templates as follows: - Interfaces (https://codereview.chromium.org/2454133002/) - Methods (https://codereview.chromium.org/2460563002/) - Attributes (https://codereview.chromium.org/2449043007/) - Others (https://codereview.chromium.org/2452403002/) Because reformatting them at once will be huge, especially for V8TestObject.cpp, and it can costs network if reverted. https://codereview.chromium.org/2446213002/ so I'd like to split it into few changes. BUG=None ==========
Description was changed from ========== Reformat methods.cpp.tmpl I'm planning to change the format of templates as follows: - Interfaces (https://codereview.chromium.org/2454133002/) - Methods (https://codereview.chromium.org/2460563002/) - Attributes (https://codereview.chromium.org/2449043007/) - Others (https://codereview.chromium.org/2452403002/) Because reformatting them at once will be huge, especially for V8TestObject.cpp, and it can costs network if reverted. https://codereview.chromium.org/2446213002/ so I'd like to split it into few changes. BUG=None ========== to ========== Reformat methods.cpp.tmpl I'm planning to change the format of templates as follows: - Interfaces (https://codereview.chromium.org/2454133002/) - Methods (https://codereview.chromium.org/2460563002/) - Attributes (this CL) - Others (https://codereview.chromium.org/2452403002/) Because reformatting them at once will be huge, especially for V8TestObject.cpp, and it can costs network if reverted. https://codereview.chromium.org/2446213002/ so I'd like to split it into few changes. BUG=None ==========
peria@chromium.org changed reviewers: + bashi@chromium.org, haraken@chromium.org, yukishiino@chromium.org
PTL
LGTM
lgtm
Description was changed from ========== Reformat methods.cpp.tmpl I'm planning to change the format of templates as follows: - Interfaces (https://codereview.chromium.org/2454133002/) - Methods (https://codereview.chromium.org/2460563002/) - Attributes (this CL) - Others (https://codereview.chromium.org/2452403002/) Because reformatting them at once will be huge, especially for V8TestObject.cpp, and it can costs network if reverted. https://codereview.chromium.org/2446213002/ so I'd like to split it into few changes. BUG=None ========== to ========== Reformat methods.cpp.tmpl I'm planning to change the format of templates as follows: - Interfaces (https://codereview.chromium.org/2454133002/) - Methods (https://codereview.chromium.org/2460563002/) - Attributes (this CL) - Others (https://codereview.chromium.org/2452403002/) Because reformatting them at once will be huge, especially for V8TestObject.cpp, and it can costs network if reverted. https://codereview.chromium.org/2446213002/ so I'd like to split it into few changes. BUG=660281 ==========
The CQ bit was checked by peria@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from haraken@chromium.org, bashi@chromium.org, yukishiino@chromium.org Link to the patchset: https://codereview.chromium.org/2449043007/#ps20001 (title: "Rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Reformat methods.cpp.tmpl I'm planning to change the format of templates as follows: - Interfaces (https://codereview.chromium.org/2454133002/) - Methods (https://codereview.chromium.org/2460563002/) - Attributes (this CL) - Others (https://codereview.chromium.org/2452403002/) Because reformatting them at once will be huge, especially for V8TestObject.cpp, and it can costs network if reverted. https://codereview.chromium.org/2446213002/ so I'd like to split it into few changes. BUG=660281 ========== to ========== Reformat methods.cpp.tmpl I'm planning to change the format of templates as follows: - Interfaces (https://codereview.chromium.org/2454133002/) - Methods (https://codereview.chromium.org/2460563002/) - Attributes (this CL) - Others (https://codereview.chromium.org/2452403002/) Because reformatting them at once will be huge, especially for V8TestObject.cpp, and it can costs network if reverted. https://codereview.chromium.org/2446213002/ so I'd like to split it into few changes. BUG=660281 ==========
Committed patchset #2 (id:20001)
Description was changed from ========== Reformat methods.cpp.tmpl I'm planning to change the format of templates as follows: - Interfaces (https://codereview.chromium.org/2454133002/) - Methods (https://codereview.chromium.org/2460563002/) - Attributes (this CL) - Others (https://codereview.chromium.org/2452403002/) Because reformatting them at once will be huge, especially for V8TestObject.cpp, and it can costs network if reverted. https://codereview.chromium.org/2446213002/ so I'd like to split it into few changes. BUG=660281 ========== to ========== Reformat methods.cpp.tmpl I'm planning to change the format of templates as follows: - Interfaces (https://codereview.chromium.org/2454133002/) - Methods (https://codereview.chromium.org/2460563002/) - Attributes (this CL) - Others (https://codereview.chromium.org/2452403002/) Because reformatting them at once will be huge, especially for V8TestObject.cpp, and it can costs network if reverted. https://codereview.chromium.org/2446213002/ so I'd like to split it into few changes. BUG=660281 Committed: https://crrev.com/a1b605811f41370d6cdc6b1ece79796f561352cc Cr-Commit-Position: refs/heads/master@{#428343} ==========
Patchset 2 (id:??) landed as https://crrev.com/a1b605811f41370d6cdc6b1ece79796f561352cc Cr-Commit-Position: refs/heads/master@{#428343}
Chromium Code Reviews
Issue
2449043007:
[Bindings] Reformat attributes.cpp.tmpl (3/4) (Closed)
