Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(547)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2449013004: Revert "Revert "Revert "Recognize and optimize a.runtimeType == b.runtimeType pattern.""" (Closed)

Created:
4 years, 1 month ago by Vyacheslav Egorov (Google)
Modified:
4 years, 1 month ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "Revert "Revert "Recognize and optimize a.runtimeType == b.runtimeType pattern.""" This reverts commit e495e100dd8ec132b5e2f971ba79ef3e4f0896e5. Commit breaks bots that are using Android devices (SIMARM is unaffected). R=rmacnak@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/16e4f2f1c2cfba38ec2a5a98b4be3dee33859623

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -1109 lines) Patch
M runtime/lib/double.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/lib/integers.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/lib/object.cc View 1 chunk +2 lines, -44 lines 0 comments Download
M runtime/lib/object_patch.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M runtime/lib/string_patch.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/vm/aot_optimizer.h View 3 chunks +1 line, -8 lines 0 comments Download
M runtime/vm/aot_optimizer.cc View 6 chunks +6 lines, -107 lines 0 comments Download
M runtime/vm/bootstrap_natives.h View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/compiler.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M runtime/vm/flow_graph.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M runtime/vm/flow_graph_inliner.h View 3 chunks +1 line, -4 lines 0 comments Download
M runtime/vm/flow_graph_inliner.cc View 3 chunks +3 lines, -36 lines 0 comments Download
M runtime/vm/intermediate_language.h View 2 chunks +0 lines, -5 lines 0 comments Download
M runtime/vm/intermediate_language.cc View 1 chunk +0 lines, -61 lines 0 comments Download
M runtime/vm/intrinsifier_arm.cc View 2 chunks +3 lines, -145 lines 0 comments Download
M runtime/vm/intrinsifier_arm64.cc View 2 chunks +3 lines, -145 lines 0 comments Download
M runtime/vm/intrinsifier_ia32.cc View 2 chunks +4 lines, -157 lines 0 comments Download
M runtime/vm/intrinsifier_mips.cc View 2 chunks +3 lines, -150 lines 0 comments Download
M runtime/vm/intrinsifier_x64.cc View 2 chunks +4 lines, -155 lines 0 comments Download
M runtime/vm/isolate.h View 1 chunk +0 lines, -3 lines 0 comments Download
M runtime/vm/jit_optimizer.cc View 1 chunk +4 lines, -11 lines 0 comments Download
M runtime/vm/method_recognizer.h View 2 chunks +0 lines, -2 lines 0 comments Download
M runtime/vm/object.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/object_store.h View 3 chunks +2 lines, -10 lines 0 comments Download
M runtime/vm/precompiler.h View 3 chunks +1 line, -13 lines 0 comments Download
M runtime/vm/precompiler.cc View 15 chunks +19 lines, -35 lines 0 comments Download
M runtime/vm/symbols.h View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Vyacheslav Egorov (Google)
4 years, 1 month ago (2016-10-26 14:53:05 UTC) #1
Vyacheslav Egorov (Google)
Committed patchset #1 (id:1) manually as 16e4f2f1c2cfba38ec2a5a98b4be3dee33859623 (presubmit successful).
4 years, 1 month ago (2016-10-26 14:53:37 UTC) #3
Florian Schneider
4 years, 1 month ago (2016-10-26 15:48:54 UTC) #4
Message was sent while issue was closed. 
On 2016/10/26 14:53:37, Vyacheslav Egorov (Google) wrote:
> Committed patchset #1 (id:1) manually as
> 16e4f2f1c2cfba38ec2a5a98b4be3dee33859623 (presubmit successful).

dbc: Eliminate redundant "revert revert" from the commit message.

Powered by Google App Engine
This is Rietveld 408576698