runtime/vm/object.h - Issue 2449013003: Don't allocate on the Dart heap during Bigint::ToCString().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/object.h

Issue 2449013003: Don't allocate on the Dart heap during Bigint::ToCString(). (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/object.h

diff --git a/runtime/vm/object.h b/runtime/vm/object.h

index 5f8ddbf1d94d59bbc00a9018c6531d13f2c1f9ab..f88285c2756c2a160db0815b19478f8a0511d191 100644

--- a/runtime/vm/object.h

+++ b/runtime/vm/object.h

@@ -6637,8 +6637,8 @@ class Bigint : public Integer {

intptr_t Used() const;

uint32_t DigitAt(intptr_t index) const;

- const char* ToDecCString(uword (*allocator)(intptr_t size)) const;

- const char* ToHexCString(uword (*allocator)(intptr_t size)) const;

+ const char* ToDecCString(Zone* zone) const;

+ const char* ToHexCString(Zone* zone) const;

static const intptr_t kBitsPerDigit = 32; // Same as _Bigint._DIGIT_BITS

static const intptr_t kBytesPerDigit = 4;

« no previous file with comments | « runtime/vm/dart_api_impl.cc ('k') | runtime/vm/object.cc » ('j') | no next file with comments »