Issue 2449013003: Don't allocate on the Dart heap during Bigint::ToCString().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2449013003: Don't allocate on the Dart heap during Bigint::ToCString(). (Closed)

Created:
4 years, 1 month ago by rmacnak

Modified:
4 years, 1 month ago

Reviewers:
regis

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 4 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+62 lines, -82 lines)			Patch
M	runtime/vm/bigint_test.cc	View	16 chunks	+42 lines, -45 lines	0 comments	Download
M	runtime/vm/dart_api_impl.cc	View	2 chunks	+3 lines, -7 lines	0 comments	Download
M	runtime/vm/object.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	runtime/vm/object.cc	View	7 chunks	+11 lines, -18 lines	0 comments	Download
M	runtime/vm/snapshot_test.cc	View	3 chunks	+4 lines, -10 lines	0 comments	Download

Total messages: 5 (2 generated)

rmacnak

4 years, 1 month ago (2016-10-31 19:49:10 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
242e34a6235db6087a0d1475d27f063a3dd69948 (presubmit successful).