Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Issue 2448993003: Correctly guard file_list modification in gclient update (Closed)

Created:
4 years, 1 month ago by agable
Modified:
4 years, 1 month ago
Reviewers:
AdliGit, smut, smut
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M gclient_scm.py View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
agable
4 years, 1 month ago (2016-10-25 17:09:35 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2448993003/1
4 years, 1 month ago (2016-10-25 17:10:10 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/tools/depot_tools/+/c3937b9128be24e1481eb9173acaef842955e5f9
4 years, 1 month ago (2016-10-25 17:13:06 UTC) #6
AdliGit
4 years, 1 month ago (2016-10-25 22:06:05 UTC) #8
smut
lgtm
4 years, 1 month ago (2016-10-25 22:29:57 UTC) #10
AdliGit
4 years, 1 month ago (2016-10-29 12:04:23 UTC) #11
Message was sent while issue was closed.
TQ..

On Oct 26, 2016 6:29 AM, <smut@google.com> wrote:

> lgtm
>
>
>
> https://codereview.chromium.org/2448993003/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

Powered by Google App Engine
This is Rietveld 408576698