recipe_modules/bot_update/resources/bot_update.py - Issue 2448983004: Log error message if os.rename fails

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: recipe_modules/bot_update/resources/bot_update.py

Issue 2448983004: Log error message if os.rename fails (Closed)

Patch Set: Log error message if os.rename fails Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: recipe_modules/bot_update/resources/bot_update.py

diff --git a/recipe_modules/bot_update/resources/bot_update.py b/recipe_modules/bot_update/resources/bot_update.py

index 3211369667372e4ec45a6b52343120b69985a912..aa772894774e82cfd85cc33ae2e176c5598542d6 100755

--- a/recipe_modules/bot_update/resources/bot_update.py

+++ b/recipe_modules/bot_update/resources/bot_update.py

@@ -299,7 +299,11 @@ def remove(target):

os.makedirs(dead_folder)

dest = path.join(dead_folder, uuid.uuid4().hex)

print 'Marking for removal %s => %s' % (target, dest)

- os.rename(target, dest)

+ try:

+ os.rename(target, dest)

+ except Exception as e:

+ print 'Error renaming %s to %s: %s' % (target, dest, str(e))

+ raise

def ensure_no_checkout(dir_names):

« no previous file with comments | « no previous file | no next file » | no next file with comments »