Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(344)

Issue 2448973003: Remove use of ChannelHandle::name from gpu/ipc/service. (Closed)

Created:
4 years, 1 month ago by Sam McNally
Modified:
4 years, 1 month ago
CC:
chromium-reviews, piman+watch_chromium.org, chrome-apps-syd-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove use of ChannelHandle::name from gpu/ipc/service. ChannelHandle will soon only support mojo handles. This CL removes use of the fields that will be removed in gpu/ipc/service. BUG=659448 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/e2824a6d83cff43802ae1cc0dba4d4613b1bd887 Cr-Commit-Position: refs/heads/master@{#427852}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -19 lines) Patch
M gpu/ipc/service/gpu_channel.h View 2 chunks +0 lines, -5 lines 0 comments Download
M gpu/ipc/service/gpu_channel.cc View 1 chunk +5 lines, -10 lines 0 comments Download
M gpu/ipc/service/gpu_channel_manager_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M gpu/ipc/service/gpu_channel_test_common.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
Sam McNally
4 years, 1 month ago (2016-10-26 09:11:55 UTC) #7
Ken Russell (switch to Gerrit)
piman, could you review this? I haven't been privy to the Mojo migration of the ...
4 years, 1 month ago (2016-10-26 22:17:38 UTC) #9
piman
lgtm
4 years, 1 month ago (2016-10-26 22:24:11 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2448973003/1
4 years, 1 month ago (2016-10-26 22:26:29 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-26 22:34:25 UTC) #13
commit-bot: I haz the power
4 years, 1 month ago (2016-10-26 22:37:03 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e2824a6d83cff43802ae1cc0dba4d4613b1bd887
Cr-Commit-Position: refs/heads/master@{#427852}

Powered by Google App Engine
This is Rietveld 408576698