Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(946)

Unified Diff: components/certificate_reporting/error_report.cc

Issue 2448943004: Add experimental feature info to certificate reports (Closed)
Patch Set: cleanup Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/certificate_reporting/error_report.cc
diff --git a/components/certificate_reporting/error_report.cc b/components/certificate_reporting/error_report.cc
index 18145e70005e5d6348615360706fc26ad400685e..f8d90f13c6fdb8e0c32e0efa4dad5cba0d0a9212 100644
--- a/components/certificate_reporting/error_report.cc
+++ b/components/certificate_reporting/error_report.cc
@@ -10,10 +10,13 @@
#include "base/strings/string_util.h"
#include "base/time/time.h"
#include "components/certificate_reporting/cert_logger.pb.h"
+#include "components/network_time/network_time_tracker.h"
#include "net/cert/cert_status_flags.h"
#include "net/cert/x509_certificate.h"
#include "net/ssl/ssl_info.h"
+using network_time::NetworkTimeTracker;
+
namespace certificate_reporting {
namespace {
@@ -120,6 +123,39 @@ void ErrorReport::SetInterstitialInfo(
interstitial_info->set_overridable(overridable == INTERSTITIAL_OVERRIDABLE);
}
+void ErrorReport::AddNetworkTimeInfo(
+ const NetworkTimeTracker* network_time_tracker) {
+ CertLoggerFeaturesInfo* features_info = cert_report_->mutable_features_info();
+ CertLoggerFeaturesInfo::NetworkTimeQueryingInfo* network_time_info =
+ features_info->mutable_network_time_querying_info();
+ network_time_info->set_network_time_queries_enabled(
+ network_time_tracker->AreTimeFetchesEnabled());
+ NetworkTimeTracker::FetchBehavior behavior =
+ network_time_tracker->GetFetchBehavior();
meacer 2016/11/04 18:44:22 nit: Inline this in the switch condition? switch(
+ CertLoggerFeaturesInfo::NetworkTimeQueryingInfo::NetworkTimeFetchBehavior
+ report_behavior;
+
+ switch (behavior) {
+ case NetworkTimeTracker::FETCH_BEHAVIOR_UNKNOWN:
+ report_behavior = CertLoggerFeaturesInfo::NetworkTimeQueryingInfo::
+ NETWORK_TIME_FETCHES_UNKNOWN;
+ break;
+ case NetworkTimeTracker::FETCHES_IN_BACKGROUND_ONLY:
+ report_behavior = CertLoggerFeaturesInfo::NetworkTimeQueryingInfo::
+ NETWORK_TIME_FETCHES_BACKGROUND_ONLY;
+ break;
+ case NetworkTimeTracker::FETCHES_ON_DEMAND_ONLY:
+ report_behavior = CertLoggerFeaturesInfo::NetworkTimeQueryingInfo::
+ NETWORK_TIME_FETCHES_ON_DEMAND_ONLY;
+ break;
+ case NetworkTimeTracker::FETCHES_IN_BACKGROUND_AND_ON_DEMAND:
+ report_behavior = CertLoggerFeaturesInfo::NetworkTimeQueryingInfo::
+ NETWORK_TIME_FETCHES_IN_BACKGROUND_AND_ON_DEMAND;
+ break;
+ }
+ network_time_info->set_network_time_query_behavior(report_behavior);
+}
+
const std::string& ErrorReport::hostname() const {
return cert_report_->hostname();
}

Powered by Google App Engine
This is Rietveld 408576698