Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(893)

Unified Diff: components/certificate_reporting/error_report.h

Issue 2448943004: Add experimental feature info to certificate reports (Closed)
Patch Set: undo more unnecessary changes Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/certificate_reporting/error_report.h
diff --git a/components/certificate_reporting/error_report.h b/components/certificate_reporting/error_report.h
index 0200dcd4304be9f3230a80a0e4d327c02f46f02d..cd36381c90fd5ad339f689d7c61a15a3ac08d138 100644
--- a/components/certificate_reporting/error_report.h
+++ b/components/certificate_reporting/error_report.h
@@ -5,9 +5,13 @@
#ifndef COMPONENTS_CERTIFICATE_REPORTING_CERTIFICATE_ERROR_REPORT_H_
#define COMPONENTS_CERTIFICATE_REPORTING_CERTIFICATE_ERROR_REPORT_H_
+#include <map>
#include <memory>
#include <string>
+namespace base {
+struct Feature;
+} // namespace base
namespace net {
class SSLInfo;
@@ -64,6 +68,13 @@ class ErrorReport {
// Gets the hostname to which this report corresponds.
const std::string& hostname() const;
+ // Populates the report with information about the given feature,
+ // including whether it is enabled or disabled and its experiment
+ // parameters.
+ void AddFeature(const std::string& feature_name,
+ bool enabled,
+ const std::map<std::string, std::string>& params);
jwd 2016/11/03 15:15:34 Hmmm, I actually liked passing the feature itself
+
private:
std::unique_ptr<CertLoggerRequest> cert_report_;
};

Powered by Google App Engine
This is Rietveld 408576698