Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Side by Side Diff: chrome/browser/ssl/cert_report_helper.cc

Issue 2448943004: Add experimental feature info to certificate reports (Closed)
Patch Set: battre comment Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/ssl/ssl_browser_tests.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ssl/cert_report_helper.h" 5 #include "chrome/browser/ssl/cert_report_helper.h"
6 6
7 #include <utility> 7 #include <utility>
8 8
9 #include "base/logging.h" 9 #include "base/logging.h"
10 #include "base/metrics/field_trial.h" 10 #include "base/metrics/field_trial.h"
11 #include "base/rand_util.h" 11 #include "base/rand_util.h"
12 #include "base/strings/string_number_conversions.h" 12 #include "base/strings/string_number_conversions.h"
13 #include "base/strings/stringprintf.h" 13 #include "base/strings/stringprintf.h"
14 #include "base/strings/utf_string_conversions.h" 14 #include "base/strings/utf_string_conversions.h"
15 #include "build/build_config.h" 15 #include "build/build_config.h"
16 #include "chrome/browser/browser_process.h"
16 #include "chrome/browser/profiles/profile.h" 17 #include "chrome/browser/profiles/profile.h"
17 #include "chrome/browser/ssl/ssl_cert_reporter.h" 18 #include "chrome/browser/ssl/ssl_cert_reporter.h"
18 #include "chrome/common/pref_names.h" 19 #include "chrome/common/pref_names.h"
19 #include "chrome/grit/generated_resources.h" 20 #include "chrome/grit/generated_resources.h"
20 #include "components/prefs/pref_service.h" 21 #include "components/prefs/pref_service.h"
21 #include "components/safe_browsing_db/safe_browsing_prefs.h" 22 #include "components/safe_browsing_db/safe_browsing_prefs.h"
22 #include "components/security_interstitials/core/controller_client.h" 23 #include "components/security_interstitials/core/controller_client.h"
23 #include "components/security_interstitials/core/metrics_helper.h" 24 #include "components/security_interstitials/core/metrics_helper.h"
24 #include "components/variations/variations_associated_data.h" 25 #include "components/variations/variations_associated_data.h"
25 #include "content/public/browser/browser_context.h" 26 #include "content/public/browser/browser_context.h"
(...skipping 75 matching lines...) Expand 10 before | Expand all | Expand 10 after
101 metrics_helper_->RecordUserInteraction( 102 metrics_helper_->RecordUserInteraction(
102 security_interstitials::MetricsHelper::EXTENDED_REPORTING_IS_ENABLED); 103 security_interstitials::MetricsHelper::EXTENDED_REPORTING_IS_ENABLED);
103 } 104 }
104 105
105 if (!ShouldReportCertificateError()) 106 if (!ShouldReportCertificateError())
106 return; 107 return;
107 108
108 std::string serialized_report; 109 std::string serialized_report;
109 certificate_reporting::ErrorReport report(request_url_.host(), ssl_info_); 110 certificate_reporting::ErrorReport report(request_url_.host(), ssl_info_);
110 111
112 report.AddNetworkTimeInfo(g_browser_process->network_time_tracker());
113
111 report.SetInterstitialInfo( 114 report.SetInterstitialInfo(
112 interstitial_reason_, user_proceeded, 115 interstitial_reason_, user_proceeded,
113 overridable_ 116 overridable_
114 ? certificate_reporting::ErrorReport::INTERSTITIAL_OVERRIDABLE 117 ? certificate_reporting::ErrorReport::INTERSTITIAL_OVERRIDABLE
115 : certificate_reporting::ErrorReport::INTERSTITIAL_NOT_OVERRIDABLE); 118 : certificate_reporting::ErrorReport::INTERSTITIAL_NOT_OVERRIDABLE);
116 119
117 if (!report.Serialize(&serialized_report)) { 120 if (!report.Serialize(&serialized_report)) {
118 LOG(ERROR) << "Failed to serialize certificate report."; 121 LOG(ERROR) << "Failed to serialize certificate report.";
119 return; 122 return;
120 } 123 }
(...skipping 30 matching lines...) Expand all
151 if (sendingThreshold >= 0.0 && sendingThreshold <= 1.0) 154 if (sendingThreshold >= 0.0 && sendingThreshold <= 1.0)
152 return base::RandDouble() <= sendingThreshold; 155 return base::RandDouble() <= sendingThreshold;
153 } 156 }
154 } 157 }
155 return false; 158 return false;
156 } 159 }
157 160
158 bool CertReportHelper::IsPrefEnabled(const char* pref) { 161 bool CertReportHelper::IsPrefEnabled(const char* pref) {
159 return GetProfile(web_contents_)->GetPrefs()->GetBoolean(pref); 162 return GetProfile(web_contents_)->GetPrefs()->GetBoolean(pref);
160 } 163 }
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/ssl/ssl_browser_tests.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698