Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(508)

Unified Diff: components/security_state/content/web_contents_security_state_model_client.cc

Issue 2448943002: Refactor SecurityStateModel/Clients for simplicity and reusability. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/security_state/content/web_contents_security_state_model_client.cc
diff --git a/chrome/browser/ssl/chrome_security_state_model_client.cc b/components/security_state/content/web_contents_security_state_model_client.cc
similarity index 74%
copy from chrome/browser/ssl/chrome_security_state_model_client.cc
copy to components/security_state/content/web_contents_security_state_model_client.cc
index 5b7097e4b4e89c8b0c8ad8d31ffc030aa4cd8fbe..f847e86401dccd0cd48b4796b4428df46033a1de 100644
--- a/chrome/browser/ssl/chrome_security_state_model_client.cc
+++ b/components/security_state/content/web_contents_security_state_model_client.cc
@@ -2,33 +2,24 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#include "chrome/browser/ssl/chrome_security_state_model_client.h"
+#include "components/security_state/content/web_contents_security_state_model_client.h"
#include <openssl/ssl.h>
+#include <string>
#include <vector>
-#include "base/command_line.h"
-#include "base/metrics/field_trial.h"
-#include "base/metrics/histogram_macros.h"
#include "base/strings/string16.h"
+#include "base/strings/string_util.h"
#include "base/strings/utf_string_conversions.h"
-#include "build/build_config.h"
-#include "chrome/browser/browser_process.h"
-#include "chrome/browser/chromeos/policy/policy_cert_service.h"
-#include "chrome/browser/chromeos/policy/policy_cert_service_factory.h"
-#include "chrome/browser/profiles/profile.h"
-#include "chrome/browser/safe_browsing/safe_browsing_service.h"
-#include "chrome/browser/safe_browsing/ui_manager.h"
-#include "chrome/grit/chromium_strings.h"
-#include "chrome/grit/generated_resources.h"
+#include "components/strings/grit/components_chromium_strings.h"
+#include "components/strings/grit/components_strings.h"
#include "content/public/browser/navigation_entry.h"
-#include "content/public/browser/navigation_handle.h"
-#include "content/public/browser/render_frame_host.h"
#include "content/public/browser/security_style_explanation.h"
#include "content/public/browser/security_style_explanations.h"
#include "content/public/browser/ssl_status.h"
#include "content/public/browser/web_contents.h"
+#include "content/public/common/content_client.h"
#include "content/public/common/origin_util.h"
#include "net/base/net_errors.h"
#include "net/cert/x509_certificate.h"
@@ -36,16 +27,12 @@
#include "net/ssl/ssl_connection_status_flags.h"
#include "ui/base/l10n/l10n_util.h"
-DEFINE_WEB_CONTENTS_USER_DATA_KEY(ChromeSecurityStateModelClient);
-
-using safe_browsing::SafeBrowsingUIManager;
-using security_state::SecurityStateModel;
+namespace security_state {
namespace {
// Note: This is a lossy operation. Not all of the policies that can be
-// expressed by a SecurityLevel (a //chrome concept) can be expressed by
-// a blink::WebSecurityStyle.
+// expressed by a SecurityLevel can be expressed by a blink::WebSecurityStyle.
blink::WebSecurityStyle SecurityLevelToSecurityStyle(
SecurityStateModel::SecurityLevel security_level) {
switch (security_level) {
@@ -67,9 +54,8 @@ blink::WebSecurityStyle SecurityLevelToSecurityStyle(
}
void AddConnectionExplanation(
- const security_state::SecurityStateModel::SecurityInfo& security_info,
+ const SecurityStateModel::SecurityInfo& security_info,
content::SecurityStyleExplanations* security_style_explanations) {
-
// Avoid showing TLS details when we couldn't even establish a TLS connection
// (e.g. for net errors) or if there was no real connection (some tests). We
// check the |connection_status| to see if there was a connection.
@@ -149,44 +135,25 @@ void AddConnectionExplanation(
description_replacements, nullptr))));
}
-// Check to see whether the security state should be downgraded to reflect
-// a Safe Browsing verdict.
-void CheckSafeBrowsingStatus(content::NavigationEntry* entry,
- content::WebContents* web_contents,
- SecurityStateModel::VisibleSecurityState* state) {
- safe_browsing::SafeBrowsingService* sb_service =
- g_browser_process->safe_browsing_service();
- if (!sb_service)
- return;
- scoped_refptr<SafeBrowsingUIManager> sb_ui_manager = sb_service->ui_manager();
- if (sb_ui_manager->IsUrlWhitelistedOrPendingForWebContents(
- entry->GetURL(), false, entry, web_contents, false)) {
- state->fails_malware_check = true;
- }
-}
-
} // namespace
-ChromeSecurityStateModelClient::ChromeSecurityStateModelClient(
+WebContentsSecurityStateModelClient::WebContentsSecurityStateModelClient(
content::WebContents* web_contents)
- : content::WebContentsObserver(web_contents),
- web_contents_(web_contents),
- security_state_model_(new SecurityStateModel()),
- logged_http_warning_on_current_navigation_(false) {
+ : web_contents_(web_contents),
+ security_state_model_(new SecurityStateModel()) {
security_state_model_->SetClient(this);
}
-ChromeSecurityStateModelClient::~ChromeSecurityStateModelClient() {}
+WebContentsSecurityStateModelClient::~WebContentsSecurityStateModelClient() {}
// static
-blink::WebSecurityStyle ChromeSecurityStateModelClient::GetSecurityStyle(
- const security_state::SecurityStateModel::SecurityInfo& security_info,
+blink::WebSecurityStyle WebContentsSecurityStateModelClient::GetSecurityStyle(
+ const SecurityStateModel::SecurityInfo& security_info,
content::SecurityStyleExplanations* security_style_explanations) {
const blink::WebSecurityStyle security_style =
SecurityLevelToSecurityStyle(security_info.security_level);
- if (security_info.security_level ==
- security_state::SecurityStateModel::HTTP_SHOW_WARNING) {
+ if (security_info.security_level == SecurityStateModel::HTTP_SHOW_WARNING) {
// If the HTTP_SHOW_WARNING field trial is in use, display an
// unauthenticated explanation explaining why the omnibox warning is
// present.
@@ -194,8 +161,7 @@ blink::WebSecurityStyle ChromeSecurityStateModelClient::GetSecurityStyle(
content::SecurityStyleExplanation(
l10n_util::GetStringUTF8(IDS_PRIVATE_USER_DATA_INPUT),
l10n_util::GetStringUTF8(IDS_PRIVATE_USER_DATA_INPUT_DESCRIPTION)));
- } else if (security_info.security_level ==
- security_state::SecurityStateModel::NONE &&
+ } else if (security_info.security_level == SecurityStateModel::NONE &&
security_info.displayed_private_user_data_input_on_http) {
// If the HTTP_SHOW_WARNING field trial isn't in use yet, display an
// informational note that the omnibox will contain a warning for
@@ -323,70 +289,20 @@ blink::WebSecurityStyle ChromeSecurityStateModelClient::GetSecurityStyle(
return security_style;
}
-void ChromeSecurityStateModelClient::GetSecurityInfo(
+void WebContentsSecurityStateModelClient::GetSecurityInfo(
SecurityStateModel::SecurityInfo* result) const {
security_state_model_->GetSecurityInfo(result);
}
-void ChromeSecurityStateModelClient::VisibleSSLStateChanged() {
- if (logged_http_warning_on_current_navigation_)
- return;
-
- security_state::SecurityStateModel::SecurityInfo security_info;
- GetSecurityInfo(&security_info);
- if (!security_info.displayed_private_user_data_input_on_http)
- return;
-
- std::string warning;
- switch (security_info.security_level) {
- case security_state::SecurityStateModel::HTTP_SHOW_WARNING:
- warning =
- "This page includes a password or credit card input in a non-secure "
- "context. A warning has been added to the URL bar. For more "
- "information, see https://goo.gl/zmWq3m.";
- break;
- case security_state::SecurityStateModel::NONE:
- warning =
- "This page includes a password or credit card input in a non-secure "
- "context. A warning will be added to the URL bar in Chrome 56 (Jan "
- "2017). For more information, see https://goo.gl/zmWq3m.";
- break;
- default:
- return;
- }
-
- logged_http_warning_on_current_navigation_ = true;
- web_contents_->GetMainFrame()->AddMessageToConsole(
- content::CONSOLE_MESSAGE_LEVEL_WARNING, warning);
-}
-
-void ChromeSecurityStateModelClient::DidFinishNavigation(
- content::NavigationHandle* navigation_handle) {
- if (navigation_handle->IsInMainFrame() &&
- !navigation_handle->IsSynchronousNavigation()) {
- // Only reset the console message flag for main-frame navigations,
- // and not for synchronous navigations like reference fragments and
- // pushState.
- logged_http_warning_on_current_navigation_ = false;
- }
-}
-
-bool ChromeSecurityStateModelClient::UsedPolicyInstalledCertificate() {
-#if defined(OS_CHROMEOS)
- policy::PolicyCertService* service =
- policy::PolicyCertServiceFactory::GetForProfile(
- Profile::FromBrowserContext(web_contents_->GetBrowserContext()));
- if (service && service->UsedPolicyCertificates())
- return true;
-#endif
+bool WebContentsSecurityStateModelClient::UsedPolicyInstalledCertificate() {
return false;
}
-bool ChromeSecurityStateModelClient::IsOriginSecure(const GURL& url) {
+bool WebContentsSecurityStateModelClient::IsOriginSecure(const GURL& url) {
return content::IsOriginSecure(url);
}
-void ChromeSecurityStateModelClient::GetVisibleSecurityState(
+void WebContentsSecurityStateModelClient::GetVisibleSecurityState(
SecurityStateModel::VisibleSecurityState* state) {
content::NavigationEntry* entry =
web_contents_->GetController().GetVisibleEntry();
@@ -399,7 +315,7 @@ void ChromeSecurityStateModelClient::GetVisibleSecurityState(
*state = SecurityStateModel::VisibleSecurityState();
// Connection security information is still being initialized, but malware
// status might already be known.
- CheckSafeBrowsingStatus(entry, web_contents_, state);
+ CheckMalwareStatus(entry, web_contents_, state);
return;
}
@@ -432,5 +348,7 @@ void ChromeSecurityStateModelClient::GetVisibleSecurityState(
!!(ssl.content_status &
content::SSLStatus::DISPLAYED_CREDIT_CARD_FIELD_ON_HTTP);
- CheckSafeBrowsingStatus(entry, web_contents_, state);
+ CheckMalwareStatus(entry, web_contents_, state);
}
+
+} // namespace security_state

Powered by Google App Engine
This is Rietveld 408576698