chrome/browser/ui/views/website_settings/website_settings_popup_view.cc - Issue 2448943002: Refactor SecurityStateModel/Clients for simplicity and reusability.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/website_settings/website_settings_popup_view.cc

Issue 2448943002: Refactor SecurityStateModel/Clients for simplicity and reusability. (Closed)

Patch Set: fix DEPS. Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/website_settings/website_settings_popup_view.h ('k') | chrome/browser/ui/views/website_settings/website_settings_popup_view_unittest.cc » ('j') | components/security_state/content/DEPS » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/website_settings/website_settings_popup_view.cc

diff --git a/chrome/browser/ui/views/website_settings/website_settings_popup_view.cc b/chrome/browser/ui/views/website_settings/website_settings_popup_view.cc

index f182aabb5062b633a24b9fe0f81990f7708ac258..0743c7aa6ccf7870d35eabd66066a94077fa3eab 100644

--- a/chrome/browser/ui/views/website_settings/website_settings_popup_view.cc

+++ b/chrome/browser/ui/views/website_settings/website_settings_popup_view.cc

@@ -418,7 +418,7 @@ void WebsiteSettingsPopupView::ShowPopup(

Profile* profile,

content::WebContents* web_contents,

const GURL& url,

- const security_state::SecurityStateModel::SecurityInfo& security_info) {

+ const security_state::SecurityInfo& security_info) {

gfx::NativeView parent_window =

anchor_view ? nullptr : web_contents->GetNativeView();

if (url.SchemeIs(content::kChromeUIScheme) ||

@@ -452,7 +452,7 @@ WebsiteSettingsPopupView::WebsiteSettingsPopupView(

Profile* profile,

content::WebContents* web_contents,

const GURL& url,

- const security_state::SecurityStateModel::SecurityInfo& security_info)

+ const security_state::SecurityInfo& security_info)

: content::WebContentsObserver(web_contents),

BubbleDialogDelegateView(anchor_view, views::BubbleBorder::TOP_LEFT),

profile_(profile),