Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2847)

Unified Diff: chrome/browser/ui/browser.cc

Issue 2448943002: Refactor SecurityStateModel/Clients for simplicity and reusability. (Closed)
Patch Set: update comments. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/browser.cc
diff --git a/chrome/browser/ui/browser.cc b/chrome/browser/ui/browser.cc
index fe651faec5dc9c3ae045fc0ec60ce8e54dfcb9f8..282bfd45f2c52fe2a5cb608e67e08de9c8c475e5 100644
--- a/chrome/browser/ui/browser.cc
+++ b/chrome/browser/ui/browser.cc
@@ -79,7 +79,7 @@
#include "chrome/browser/sessions/session_service_factory.h"
#include "chrome/browser/sessions/session_tab_helper.h"
#include "chrome/browser/sessions/tab_restore_service_factory.h"
-#include "chrome/browser/ssl/chrome_security_state_model_client.h"
+#include "chrome/browser/ssl/security_state_tab_helper.h"
#include "chrome/browser/sync/profile_sync_service_factory.h"
#include "chrome/browser/sync/sync_ui_util.h"
#include "chrome/browser/tab_contents/retargeting_details.h"
@@ -167,7 +167,8 @@
#include "components/history/core/browser/top_sites.h"
#include "components/prefs/pref_service.h"
#include "components/search/search.h"
-#include "components/security_state/security_state_model.h"
+#include "components/security_state/content/content_utils.h"
+#include "components/security_state/core/security_state_model.h"
#include "components/sessions/core/session_types.h"
#include "components/sessions/core/tab_restore_service.h"
#include "components/startup_metric_utils/browser/startup_metric_utils.h"
@@ -1279,13 +1280,13 @@ bool Browser::CanDragEnter(content::WebContents* source,
blink::WebSecurityStyle Browser::GetSecurityStyle(
WebContents* web_contents,
content::SecurityStyleExplanations* security_style_explanations) {
- ChromeSecurityStateModelClient* model_client =
- ChromeSecurityStateModelClient::FromWebContents(web_contents);
- DCHECK(model_client);
+ SecurityStateTabHelper* helper =
+ SecurityStateTabHelper::FromWebContents(web_contents);
+ DCHECK(helper);
security_state::SecurityStateModel::SecurityInfo security_info;
- model_client->GetSecurityInfo(&security_info);
- return model_client->GetSecurityStyle(security_info,
- security_style_explanations);
+ helper->GetSecurityInfo(&security_info);
+ return security_state_content_utils::GetSecurityStyle(
+ security_info, security_style_explanations);
}
void Browser::ShowCertificateViewerInDevTools(
@@ -1431,9 +1432,9 @@ void Browser::VisibleSecurityStateChanged(WebContents* source) {
if (tab_strip_model_->GetActiveWebContents() == source)
UpdateToolbar(false);
- ChromeSecurityStateModelClient* security_model =
- ChromeSecurityStateModelClient::FromWebContents(source);
- security_model->VisibleSecurityStateChanged();
+ SecurityStateTabHelper* helper =
+ SecurityStateTabHelper::FromWebContents(source);
+ helper->VisibleSecurityStateChanged();
}
void Browser::AddNewContents(WebContents* source,

Powered by Google App Engine
This is Rietveld 408576698